Skip to content

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented Nov 22, 2014

Link to #3352

@SparkQA
Copy link

SparkQA commented Nov 22, 2014

Test build #23738 has started for PR 3414 at commit 2e04cd3.

  • This patch merges cleanly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this

@SparkQA
Copy link

SparkQA commented Nov 22, 2014

Test build #23740 has started for PR 3414 at commit d563124.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 22, 2014

Test build #23738 has finished for PR 3414 at commit 2e04cd3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23738/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 22, 2014

Test build #23740 has finished for PR 3414 at commit d563124.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23740/
Test PASSed.

@marmbrus
Copy link
Contributor

I don't think we want to set this flag to always be true otherwise its not possible to read binary data anymore. A reasonable thing to do would be override the conf when the convertMetastoreParquet code path is taken so at least then we are faithfully mimicking hive's behavior.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23810 has started for PR 3414 at commit 9c85c22.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23810 has finished for PR 3414 at commit 9c85c22.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23810/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be mutating configuration when accessing a setting. Also, I think that #3441 is going to solve this problem so perhaps we can close this issue?

@scwf
Copy link
Contributor Author

scwf commented Dec 2, 2014

Ok, if @liancheng fix them, i will close this two PR.

@marmbrus
Copy link
Contributor

mind closing this manually? or script seems to be missing it.

@scwf
Copy link
Contributor Author

scwf commented Dec 18, 2014

ok to close this

@scwf scwf closed this Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants