Skip to content

[SPARK-33298][CORE][FOLLOWUP] Move FileNameSpec into FileCommitProtocol object #33565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
c21 wants to merge 1 commit into from
Closed

[SPARK-33298][CORE][FOLLOWUP] Move FileNameSpec into FileCommitProtocol object #33565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,15 @@ object FileCommitProtocol extends Logging {

object EmptyTaskCommitMessage extends TaskCommitMessage(null)

/**
* The specification for Spark output file name.
* This is used by [[FileCommitProtocol]] to create full path of file.
*
* @param prefix Prefix of file.
* @param suffix Suffix of file.
*/
final case class FileNameSpec(prefix: String, suffix: String)

/**
* Instantiates a FileCommitProtocol using the given className.
*/
Expand Down Expand Up @@ -231,12 +240,3 @@ object FileCommitProtocol extends Logging {
new Path(path, ".spark-staging-" + jobId)
}
}

/**
* The specification for Spark output file name.
* This is used by [[FileCommitProtocol]] to create full path of file.
*
* @param prefix Prefix of file.
* @param suffix Suffix of file.
*/
final case class FileNameSpec(prefix: String, suffix: String)
Copy link
Contributor

@cloud-fan cloud-fan Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a public class?

Copy link
Contributor Author

@c21 c21 Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because the companion object is defined here, so it cannot be imported in other files.

Copy link
Contributor Author

@c21 c21 Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wait a second, let me double check. Sorry for the rush.