[SPARK-33298][CORE][FOLLOWUP] Move FileNameSpec into FileCommitProtocol object
#33565
Conversation
|
cc @cloud-fan could you help take a look when you have time? Thanks. |
|
Kubernetes integration test starting |
| * @param prefix Prefix of file. | ||
| * @param suffix Suffix of file. | ||
| */ | ||
| final case class FileNameSpec(prefix: String, suffix: String) |
There was a problem hiding this comment.
isn't this a public class?
There was a problem hiding this comment.
I think because the companion object is defined here, so it cannot be imported in other files.
There was a problem hiding this comment.
Actually wait a second, let me double check. Sorry for the rush.
|
@cloud-fan, sorry for the red herring, it's actually not an issue as I made a mistake when doing import in #33432 . Thanks for taking a look, and closing this now. |
|
Kubernetes integration test status failure |
|
Test build #141796 has finished for PR 33565 at commit
|
3 participants
What changes were proposed in this pull request?
This is followup of #33012, where we defined
FileNameSpecin the file ofFileCommitProtocol.scala. When making the change of #33432, I found theFileNameSpecis not accessible outside of its file, because the companion objectFileCommitProtocolexists. So the fix is to move theFileNameSpecdefinition into companion objectFileCommitProtocol, then it can be accessible outside.Why are the changes needed?
Fix the code logic.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit test, and end-to-end test in #33432 as well.