Skip to content

[SPARK-35151][BUILD] Add compile arg to suppress symbol literal is deprecated compilation warnings in Scala 2.13 #32261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 2 commits into from
Closed

[SPARK-35151][BUILD] Add compile arg to suppress symbol literal is deprecated compilation warnings in Scala 2.13 #32261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c97fc9
Add a rule to supress symbol literal is deprecated
LuciferYang Apr 20, 2021
56ba63c
Merge branch 'upmaster' into SPARK-35151
LuciferYang Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3385,6 +3385,7 @@
<arg>-Wconf:msg=Auto-application to \`\(\)\` is deprecated:s</arg>
<arg>-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s</arg>
<arg>-Wconf:msg=method without a parameter list overrides a method with a single empty one:s</arg>
<arg>-Wconf:msg=symbol literal is deprecated:s</arg>
Copy link
Member

@HyukjinKwon HyukjinKwon Apr 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have any feedback before we ignoring the symbol literal deprecations?

Copy link
Contributor Author

@LuciferYang LuciferYang Apr 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon I think this may be a compromise for #31569 if we don't plan to fix it recently. I just asked in #31569, there is no other feedback for the time being except for @cloud-fan.

Copy link
Contributor

@cloud-fan cloud-fan Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only choice for now as we don't want to remove the symbol usage in Spark. We can rely on the Scala feature import and ask the Scala community to keep it forever. If it's removed in the future, we can change the Spark code at that time.

Copy link
Member

@HyukjinKwon HyukjinKwon Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if we're going to keep them explicitly, I'm fine.

Copy link
Contributor

@cloud-fan cloud-fan Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are new updates in #31569 ...

Copy link
Member

@srowen srowen Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I'm still not clear why we can't replace 'foo with Symbol(foo). That does not remove usage of Symbol. It just removes usage of the deprecated literal syntax. I thought the resolution was that this much was fine? the other issue is kind of conflating the deprecated syntax and Symbol itself.

Copy link
Contributor

@cloud-fan cloud-fan Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use symbol literal in our testing DSL because it's easy to write. If we need to write Symbol("foo") from now on, I'd vote for updating the test DSL and pick a different syntax, such as #31601

Copy link
Member

@srowen srowen Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's not as compact. I'm OK with just suppressing it too, if the code churn is too much of a PITA.

</args>
<compilerPlugins combine.self="override">
</compilerPlugins>
Expand Down
3 changes: 2 additions & 1 deletion project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ object SparkBuild extends PomBuild {
"-Wconf:msg=^(?=.*?Widening conversion from)(?=.*?is deprecated because it loses precision).+$:s",
"-Wconf:msg=Auto-application to \\`\\(\\)\\` is deprecated:s",
"-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s",
"-Wconf:msg=method without a parameter list overrides a method with a single empty one:s"
"-Wconf:msg=method without a parameter list overrides a method with a single empty one:s",
"-Wconf:msg=symbol literal is deprecated:s"
)
}
}
Expand Down