[SPARK-35151][BUILD] Add compile arg to suppress symbol literal is deprecated compilation warnings in Scala 2.13
#32261
Conversation
|
cc @cloud-fan |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #137694 has finished for PR 32261 at commit
|
| <arg>-Wconf:msg=Auto-application to \`\(\)\` is deprecated:s</arg> | ||
| <arg>-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s</arg> | ||
| <arg>-Wconf:msg=method without a parameter list overrides a method with a single empty one:s</arg> | ||
| <arg>-Wconf:msg=symbol literal is deprecated:s</arg> |
There was a problem hiding this comment.
Can we have any feedback before we ignoring the symbol literal deprecations?
There was a problem hiding this comment.
@HyukjinKwon I think this may be a compromise for #31569 if we don't plan to fix it recently. I just asked in #31569, there is no other feedback for the time being except for @cloud-fan.
There was a problem hiding this comment.
I think this is the only choice for now as we don't want to remove the symbol usage in Spark. We can rely on the Scala feature import and ask the Scala community to keep it forever. If it's removed in the future, we can change the Spark code at that time.
There was a problem hiding this comment.
Okay, if we're going to keep them explicitly, I'm fine.
There was a problem hiding this comment.
Wait, I'm still not clear why we can't replace 'foo with Symbol(foo). That does not remove usage of Symbol. It just removes usage of the deprecated literal syntax. I thought the resolution was that this much was fine? the other issue is kind of conflating the deprecated syntax and Symbol itself.
There was a problem hiding this comment.
We use symbol literal in our testing DSL because it's easy to write. If we need to write Symbol("foo") from now on, I'd vote for updating the test DSL and pick a different syntax, such as #31601
There was a problem hiding this comment.
Yeah it's not as compact. I'm OK with just suppressing it too, if the code churn is too much of a PITA.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138038 has finished for PR 32261 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
5 participants
What changes were proposed in this pull request?
There are some compilation warnings in Scala 2.13 as follows:
The main change of this pr is add a compile arg to temporarily suppress these compilation warnings to make compile log look cleaner.
Why are the changes needed?
Temporarily suppress
symbol literal is deprecatedcompilation warnings to make compile log look cleaner.Does this PR introduce any user-facing change?
No
How was this patch tested?
symbol literal is deprecatedrelated warnings are no longer included in the compilation log