[SPARK-33498][SQL][TESTS][3.1][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite #31813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @dongjoon-hyun |
HyukjinKwon
approved these changes
Mar 12, 2021
dongjoon-hyun
approved these changes
Mar 12, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you.
Member
|
This is a test-only PR and I verified the test suite manually. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 12, 2021
…onf in CastSuite ### What changes were proposed in this pull request? This PR intends to remove unnecessary `SQLConf.withExistingConf` in `CastSuite`; since we've remove `ParVector ` in #31775, we no longer need to copy SQL configs into each thread env. This PR is a backport of #31785. ### Why are the changes needed? Clean up the code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run the existing tests. Closes #31813 from maropu/SPARK-33498-BRANCH3.1. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
Thanks, @dongjoon-hyun @HyukjinKwon ~ |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…onf in CastSuite ### What changes were proposed in this pull request? This PR intends to remove unnecessary `SQLConf.withExistingConf` in `CastSuite`; since we've remove `ParVector ` in apache#31775, we no longer need to copy SQL configs into each thread env. This PR is a backport of apache#31785. ### Why are the changes needed? Clean up the code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run the existing tests. Closes apache#31813 from maropu/SPARK-33498-BRANCH3.1. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR intends to remove unnecessary
SQLConf.withExistingConfinCastSuite; since we've removeParVectorin #31775, we no longer need to copy SQL configs into each thread env.This PR is a backport of #31785.
Why are the changes needed?
Clean up the code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run the existing tests.