[SPARK-33498][SQL][TESTS][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite #31785
Conversation
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a follow-up, @maropu .
dongjoon-hyun
changed the title
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
This is a test-only PR and I verified manually.
[info] All tests passed.
[info] Passed: Total 4879, Failed 0, Errors 0, Passed 4879, Ignored 5
[success] Total time: 369 s (06:09), completed Mar 8, 2021 11:51:30 PM
build/sbt "catalyst/test" 1393.45s user 42.65s system 380% cpu 6:16.93 total
Merged to master.
|
There is a conflict on branch-3.1. Could you make a backporting PR? |
|
Oh, BTW, @maropu . |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Thanks for your quick review&merge! I'll open a PR for that later.
Ah, yea, as you said, it looks a bit weird. But, this is a minor update, so IMO it is okay as it is. Or, do you think we need to do anything for that? |
|
It's not a problem. I thought it was a follow-up of SPARK-34660 . But, according to this PR's content, it's more proper as a follow-up of SPARK-33498 . Maybe, next time, we had better create a new JIRA for a released patch because the |
…onf in CastSuite ### What changes were proposed in this pull request? This PR intends to remove unnecessary `SQLConf.withExistingConf` in `CastSuite`; since we've remove `ParVector ` in #31775, we no longer need to copy SQL configs into each thread env. This PR is a backport of #31785. ### Why are the changes needed? Clean up the code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run the existing tests. Closes #31813 from maropu/SPARK-33498-BRANCH3.1. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…onf in CastSuite ### What changes were proposed in this pull request? This PR intends to remove unnecessary `SQLConf.withExistingConf` in `CastSuite`; since we've remove `ParVector ` in apache#31775, we no longer need to copy SQL configs into each thread env. This PR is a backport of apache#31785. ### Why are the changes needed? Clean up the code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run the existing tests. Closes apache#31813 from maropu/SPARK-33498-BRANCH3.1. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
3 participants
What changes were proposed in this pull request?
This PR intends to remove unnecessary
SQLConf.withExistingConfinCastSuite; since we've removeParVectorin #31775, we no longer need to copy SQL configs into each thread env.Why are the changes needed?
Clean up the code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run the existing tests.