[SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3 #31660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
SPARK-34551
branch
from
6e58017 to
ab90586
Compare
cloud-fan
approved these changes
Feb 26, 2021
srowen
approved these changes
Feb 26, 2021
HyukjinKwon
force-pushed
the
SPARK-34551
branch
from
ab90586 to
6b510a0
Compare
Member
Author
|
Thanks guys. I just made a simple cleanup. I will merge this once linters pass. |
HyukjinKwon
commented
Feb 26, 2021
| try: | ||
| import unidecode | ||
| except ImportError: | ||
| print("This tool requires the unidecode library to decode obscure github usernames") |
Member
Author
There was a problem hiding this comment.
Just to clarify, I think now most of release docs, notes, and everywhere else can handle UFT-8 properly, and we don't have to force and mangle other people's name into ASCII. I believe this was initially introduced due to unicode and Python 2's string handling. If there's an issue, we believe we should try to fix it instead of manipulating author's names.
Member
Author
|
Merged to master and branch-3.1. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 26, 2021
…on 2 and work with Python 3 ### What changes were proposed in this pull request? This PR proposes to make the scripts working by: - Recovering credit related scripts that were broken from #29563 `raw_input` does not exist in `releaseutils` but only in Python 2 - Dropping Python 2 in these scripts because we dropped Python 2 in #28957 - Making these scripts workin with Python 3 ### Why are the changes needed? To unblock the release. ### Does this PR introduce _any_ user-facing change? No, it's dev-only change. ### How was this patch tested? I manually tested against Spark 3.1.1 RC3. Closes #31660 from HyukjinKwon/SPARK-34551. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 5b92531) Signed-off-by: HyukjinKwon <[email protected]>
|
Test build #135502 has finished for PR 31660 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make the scripts working by:
raw_inputdoes not exist inreleaseutilsbut only in Python 2Why are the changes needed?
To unblock the release.
Does this PR introduce any user-facing change?
No, it's dev-only change.
How was this patch tested?
I manually tested against Spark 3.1.1 RC3.