Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 6, 2021

What changes were proposed in this pull request?

This PR aims to add ZStandardBenchmark as a base-line.

Why are the changes needed?

This will prevent any regression when we upgrade Zstandard library in the future.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually.

@github-actions github-actions bot added the CORE label Feb 6, 2021
@SparkQA
Copy link

SparkQA commented Feb 6, 2021

Test build #134960 has finished for PR 31498 at commit 5f681ba.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @HyukjinKwon , @maropu , @viirya ? This is a baseline for ZStandardCompression to prevent any regression in the future.

Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@dongjoon-hyun
Copy link
Member Author

Oh, thank you, @maropu and @viirya !

@dongjoon-hyun
Copy link
Member Author

Merged to master because this is irrelevant to the UT or IT.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-ZSTD-BENCH branch February 6, 2021 23:35
@SparkQA
Copy link

SparkQA commented Feb 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39547/

@SparkQA
Copy link

SparkQA commented Feb 7, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39547/

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm2

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

@SparkQA
Copy link

SparkQA commented Feb 7, 2021

Test build #134964 has finished for PR 31498 at commit 870ffdf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
### What changes were proposed in this pull request?

This PR aims to add ZStandardBenchmark as a base-line.

### Why are the changes needed?

This will prevent any regression when we upgrade Zstandard library in the future.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually.

Closes apache#31498 from dongjoon-hyun/SPARK-ZSTD-BENCH.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants