Skip to content

[MINOR][ML] Param Validation should throw IllegalArgumentException #31469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[MINOR][ML] Param Validation should throw IllegalArgumentException #31469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/feature/Selector.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ private[ml] abstract class Selector[T <: SelectorModel[T]]
.where(col("pValue") < $(fwe) / numFeatures)
.as[Int].collect()
case errorType =>
throw new IllegalStateException(s"Unknown Selector Type: $errorType")
throw new IllegalArgumentException(s"Unknown Selector Type: $errorType")
}

copyValues(createSelectorModel(uid, indices.sorted)
Expand Down
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ class ChiSqSelector @Since("2.1.0") () extends Serializable {
chiSqTestResult
.filter { case (res, _) => res.pValue < fwe / chiSqTestResult.length }
case errorType =>
throw new IllegalStateException(s"Unknown ChiSqSelector Type: $errorType")
throw new IllegalArgumentException(s"Unknown ChiSqSelector Type: $errorType")
}
val indices = features.map { case (_, index) => index }
new ChiSqSelectorModel(indices)
Expand Down