Skip to content

[MINOR][ML] Param Validation should throw IllegalArgumentException #31469

Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:mllib_exceptions
Closed

[MINOR][ML] Param Validation should throw IllegalArgumentException #31469
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:mllib_exceptions

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Param Validation throw IllegalArgumentException

Why are the changes needed?

Param Validation should throw IllegalArgumentException instead of IllegalStateException

Does this PR introduce any user-facing change?

Yes, the type of exception changed

How was this patch tested?

existing testsuites

@zhengruifeng
Copy link
Contributor Author

ping @huaxingao @srowen

@SparkQA
Copy link

SparkQA commented Feb 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39452/

@SparkQA
Copy link

SparkQA commented Feb 4, 2021

Test build #134864 has finished for PR 31469 at commit 40a9a53.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 4, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39452/

@zhengruifeng
Copy link
Contributor Author

merged to master, thanks all!

@zhengruifeng zhengruifeng deleted the mllib_exceptions branch February 5, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants