[SPARK-34021][R] Fix hyper links in SparkR documentation for CRAN submission #31058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 6, 2021
Member
Author
|
cc @felixcheung and @shivaram. I think we can just start it from Spark 3.1.0 on CRAN. BTW, I verified all commits that added http(s) links to the docs after Spark 3.0.0: their links look all valid and there's no more move or redirections here that are new in Spark 3.1. So only fixing the two problems pointed out for Spark 3.0.1 should work. |
Member
Author
|
Wow, thanks @dongjoon-hyun. |
MaxGekk
reviewed
Jan 6, 2021
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Manually tested by clicking the links
Can we do that automatically on our side?
Member
Author
|
Not sure. I should I ask what kind of tool they use, actually. Ideally that should be part of |
|
Test build #133719 has finished for PR 31058 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
Author
|
Merged to master and branch-3.1 |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 7, 2021
…mission
### What changes were proposed in this pull request?
3.0.1 CRAN submission was failed as the reason below:
```
Found the following (possibly) invalid URLs:
URL: http://jsonlines.org/ (moved to https://jsonlines.org/)
From: man/read.json.Rd
man/write.json.Rd
Status: 200
Message: OK
URL: https://dl.acm.org/citation.cfm?id=1608614 (moved to
https://dl.acm.org/doi/10.1109/MC.2009.263)
From: inst/doc/sparkr-vignettes.html
Status: 200
Message: OK
```
The links were being redirected now. This PR checked all hyperlinks in the docs such as `href{...}` and `url{...}`, and fixed all in SparkR:
- Fix two problems above.
- Fix http to https
- Fix `https://www.apache.org/ https://spark.apache.org/` -> `https://www.apache.org https://spark.apache.org`.
### Why are the changes needed?
For CRAN submission.
### Does this PR introduce _any_ user-facing change?
Virtually no because it's just cleanup that CRAN requires.
### How was this patch tested?
Manually tested by clicking the links
Closes #31058 from HyukjinKwon/SPARK-34021.
Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit 0ba3ab4)
Signed-off-by: HyukjinKwon <[email protected]>
sumwale
pushed a commit
to TIBCOSoftware/snappy-spark
that referenced
this pull request
Jun 29, 2022
…mission
3.0.1 CRAN submission was failed as the reason below:
```
Found the following (possibly) invalid URLs:
URL: http://jsonlines.org/ (moved to https://jsonlines.org/)
From: man/read.json.Rd
man/write.json.Rd
Status: 200
Message: OK
URL: https://dl.acm.org/citation.cfm?id=1608614 (moved to
https://dl.acm.org/doi/10.1109/MC.2009.263)
From: inst/doc/sparkr-vignettes.html
Status: 200
Message: OK
```
The links were being redirected now. This PR checked all hyperlinks in the docs such as `href{...}` and `url{...}`, and fixed all in SparkR:
- Fix two problems above.
- Fix http to https
- Fix `https://www.apache.org/ https://spark.apache.org/` -> `https://www.apache.org https://spark.apache.org`.
For CRAN submission.
Virtually no because it's just cleanup that CRAN requires.
Manually tested by clicking the links
Closes apache#31058 from HyukjinKwon/SPARK-34021.
Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
3.0.1 CRAN submission was failed as the reason below:
The links were being redirected now. This PR checked all hyperlinks in the docs such as
href{...}andurl{...}, and fixed all in SparkR:https://www.apache.org/ https://spark.apache.org/->https://www.apache.org https://spark.apache.org.Why are the changes needed?
For CRAN submission.
Does this PR introduce any user-facing change?
Virtually no because it's just cleanup that CRAN requires.
How was this patch tested?
Manually tested by clicking the links