[MINOR][R][DOCS] Rewrite \url to \href, if name is provided #34714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Nov 25, 2021
|
Test build #145638 has finished for PR 34714 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces
\urlcommands with\href, when alias is provided.Why are the changes needed?
\urlis applicable only to links which have no aliases ‒ https://roxygen2.r-lib.org/articles/rd-formatting.html#links-1As a result, some the links are not rendered as expected
After this PR is merged, will get expected results, with
hrefapplied to provided textDoes this PR introduce any user-facing change?
Docs only, as described above.
How was this patch tested?
Docs build and manual inspection of the results.