-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33210][SQL] Set the rebasing mode for parquet INT96 type to EXCEPTION by default
#30121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6877ac3
Set configs to EXCEPTION by default
MaxGekk 6c4be00
Update the SQL migration guide.
MaxGekk 5a6b92b
Fix ParquetHadoopFsRelationSuite
MaxGekk 4bfb96b
Fix StatisticsSuite
MaxGekk f0c4ef1
Fix ParquetIOSuite
MaxGekk 33bb5c2
Fix ParquetFilterSuite
MaxGekk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1513,26 +1513,27 @@ class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleto | |
| Seq(tbl, ext_tbl).foreach { tblName => | ||
| sql(s"INSERT INTO $tblName VALUES (1, 'a', '2019-12-13')") | ||
|
|
||
| val expectedSize = 636 | ||
| // analyze table | ||
| sql(s"ANALYZE TABLE $tblName COMPUTE STATISTICS NOSCAN") | ||
| var tableStats = getTableStats(tblName) | ||
| assert(tableStats.sizeInBytes == 601) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The size of the parquet files increased because we write metadata key |
||
| assert(tableStats.sizeInBytes == expectedSize) | ||
| assert(tableStats.rowCount.isEmpty) | ||
|
|
||
| sql(s"ANALYZE TABLE $tblName COMPUTE STATISTICS") | ||
| tableStats = getTableStats(tblName) | ||
| assert(tableStats.sizeInBytes == 601) | ||
| assert(tableStats.sizeInBytes == expectedSize) | ||
| assert(tableStats.rowCount.get == 1) | ||
|
|
||
| // analyze a single partition | ||
| sql(s"ANALYZE TABLE $tblName PARTITION (ds='2019-12-13') COMPUTE STATISTICS NOSCAN") | ||
| var partStats = getPartitionStats(tblName, Map("ds" -> "2019-12-13")) | ||
| assert(partStats.sizeInBytes == 601) | ||
| assert(partStats.sizeInBytes == expectedSize) | ||
| assert(partStats.rowCount.isEmpty) | ||
|
|
||
| sql(s"ANALYZE TABLE $tblName PARTITION (ds='2019-12-13') COMPUTE STATISTICS") | ||
| partStats = getPartitionStats(tblName, Map("ds" -> "2019-12-13")) | ||
| assert(partStats.sizeInBytes == 601) | ||
| assert(partStats.sizeInBytes == expectedSize) | ||
| assert(partStats.rowCount.get == 1) | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No info about the writer. We take the mode from the SQL config and fail by default.