[SPARK-33210][SQL] Set the rebasing mode for parquet INT96 type to EXCEPTION by default
#30121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #130099 has finished for PR 30121 at commit
|
MaxGekk
changed the title
EXCEPTION by defaultEXCEPTION by default
Member
Author
|
@HyukjinKwon @cloud-fan @tomvanbussel @ala Please, review this PR. |
MaxGekk
commented
Oct 21, 2020
| // analyze table | ||
| sql(s"ANALYZE TABLE $tblName COMPUTE STATISTICS NOSCAN") | ||
| var tableStats = getTableStats(tblName) | ||
| assert(tableStats.sizeInBytes == 601) |
Member
Author
There was a problem hiding this comment.
The size of the parquet files increased because we write metadata key org.apache.spark.int96NoRebase.
MaxGekk
commented
Oct 21, 2020
| } | ||
| Seq( | ||
| "2_4_5" -> successInRead _, | ||
| "2_4_5" -> failInRead _, |
Member
Author
There was a problem hiding this comment.
No info about the writer. We take the mode from the SQL config and fail by default.
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #130105 has finished for PR 30121 at commit
|
cloud-fan
approved these changes
Oct 22, 2020
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Oct 22, 2020
…ache.spark.int96NoRebase` by `org.apache.spark.legacyINT96`
### What changes were proposed in this pull request?
1. Replace the metadata key `org.apache.spark.int96NoRebase` by `org.apache.spark.legacyINT96`.
2. Change the condition when new key should be saved to parquet metadata: it should be saved when the SQL config `spark.sql.legacy.parquet.int96RebaseModeInWrite` is set to `LEGACY`.
3. Change handling the metadata key in read:
- If there is no the key in parquet metadata, take the rebase mode from the SQL config: `spark.sql.legacy.parquet.int96RebaseModeInRead`
- If parquet files were saved by Spark < 3.1.0, use the `LEGACY` rebasing mode for INT96 type.
- For files written by Spark >= 3.1.0, if the `org.apache.spark.legacyINT96` presents in metadata, perform rebasing otherwise don't.
### Why are the changes needed?
- To not increase parquet size by default when `spark.sql.legacy.parquet.int96RebaseModeInWrite` is `EXCEPTION` after #30121.
- To have the implementation similar to `org.apache.spark.legacyDateTime`
- To minimise impact on other subsystems that are based on file sizes like gathering statistics.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Modified test in `ParquetIOSuite`
Closes #30132 from MaxGekk/int96-flip-metadata-rebase-key.
Authored-by: Max Gekk <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
a0x8o
added a commit
to a0x8o/spark
that referenced
this pull request
Oct 22, 2020
…ache.spark.int96NoRebase` by `org.apache.spark.legacyINT96`
### What changes were proposed in this pull request?
1. Replace the metadata key `org.apache.spark.int96NoRebase` by `org.apache.spark.legacyINT96`.
2. Change the condition when new key should be saved to parquet metadata: it should be saved when the SQL config `spark.sql.legacy.parquet.int96RebaseModeInWrite` is set to `LEGACY`.
3. Change handling the metadata key in read:
- If there is no the key in parquet metadata, take the rebase mode from the SQL config: `spark.sql.legacy.parquet.int96RebaseModeInRead`
- If parquet files were saved by Spark < 3.1.0, use the `LEGACY` rebasing mode for INT96 type.
- For files written by Spark >= 3.1.0, if the `org.apache.spark.legacyINT96` presents in metadata, perform rebasing otherwise don't.
### Why are the changes needed?
- To not increase parquet size by default when `spark.sql.legacy.parquet.int96RebaseModeInWrite` is `EXCEPTION` after apache/spark#30121.
- To have the implementation similar to `org.apache.spark.legacyDateTime`
- To minimise impact on other subsystems that are based on file sizes like gathering statistics.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Modified test in `ParquetIOSuite`
Closes #30132 from MaxGekk/int96-flip-metadata-rebase-key.
Authored-by: Max Gekk <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.sql.legacy.parquet.int96RebaseModeInWriteandspark.sql.legacy.parquet.int96RebaseModeInReadtoEXCEPTION.Why are the changes needed?
Current default value
LEGACYmay lead to shifting timestamps in read or in write. We should leave the decision about rebasing to users.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
By existing test suites like
ParquetIOSuite.