-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-4111 [MLlib] add regression metrics #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
43bb12b
2e56282
d454909
a8ad3e3
3d0bec1
730d0a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.mllib.evaluation | ||
|
|
||
| import org.apache.spark.annotation.Experimental | ||
| import org.apache.spark.rdd.RDD | ||
| import org.apache.spark.Logging | ||
| import org.apache.spark.mllib.linalg.Vectors | ||
| import org.apache.spark.mllib.stat.MultivariateOnlineSummarizer | ||
| import org.apache.spark.mllib.rdd.RDDFunctions._ | ||
|
|
||
| /** | ||
| * :: Experimental :: | ||
| * Evaluator for regression. | ||
| * | ||
| * @param valuesAndPreds an RDD of (value, pred) pairs. | ||
| */ | ||
| @Experimental | ||
| class RegressionMetrics(valuesAndPreds: RDD[(Double, Double)]) extends Logging { | ||
|
|
||
| /** | ||
| * Use MultivariateOnlineSummarizer to calculate mean and variance of different combination. | ||
| * MultivariateOnlineSummarizer is a numerically stable algorithm to compute mean and variance | ||
| * in a online fashion. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The second sentence is not necessary, which is the doc for |
||
| */ | ||
| private lazy val summarizer: MultivariateOnlineSummarizer = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor: I would recommend renaming |
||
| val summarizer: MultivariateOnlineSummarizer = valuesAndPreds.map{ | ||
| case (value,pred) => Vectors.dense( | ||
| Array(value, value - pred, math.abs(value - pred), math.pow(value - pred, 2.0)) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also picky but you can avoid
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The third and the forth columns are not necessary. You can use |
||
| ) | ||
| }.treeAggregate(new MultivariateOnlineSummarizer())( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: |
||
| (summary, v) => summary.add(v), | ||
| (sum1,sum2) => sum1.merge(sum2) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. space after |
||
| ) | ||
| summarizer | ||
| } | ||
|
|
||
| /** | ||
| * Computes the explained variance regression score | ||
| */ | ||
| def explainedVarianceScore(): Double = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a quite minor point, you might want to remove the |
||
| 1 - summarizer.variance(1) / summarizer.variance(0) | ||
| } | ||
|
|
||
| /** | ||
| * Computes the mean absolute error, which is a risk function corresponding to the | ||
| * expected value of the absolute error loss or l1-norm loss. | ||
| */ | ||
| def mae(): Double = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 on @srowen 's suggestion |
||
| summarizer.mean(2) | ||
| } | ||
|
|
||
| /** | ||
| * Computes the mean square error, which is a risk function corresponding to the | ||
| * expected value of the squared error loss or quadratic loss. | ||
| */ | ||
| def mse(): Double = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I recommend adding |
||
| summarizer.mean(3) | ||
| } | ||
|
|
||
| /** | ||
| * Computes R^2^, the coefficient of determination. | ||
| * @return | ||
| */ | ||
| def r2_score(): Double = { | ||
| 1 - summarizer.mean(3) * summarizer.count / (summarizer.variance(0) * (summarizer.count - 1)) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this might be worth a comment to explain what sums of squares you are trying to compute in the numerator and denominator. A link to the definition might be good, here and for explained variance, since they are related. |
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.mllib.evaluation | ||
|
|
||
| import org.scalatest.FunSuite | ||
| import org.apache.spark.mllib.util.LocalSparkContext | ||
| import org.apache.spark.mllib.util.TestingUtils._ | ||
|
|
||
| class RegressionMetricsSuite extends FunSuite with LocalSparkContext { | ||
|
|
||
| test("regression metrics") { | ||
| val valuesAndPreds = sc.parallelize( | ||
| Seq((3.0,2.5),(-0.5,0.0),(2.0,2.0),(7.0,8.0)),2) | ||
| val metrics = new RegressionMetrics(valuesAndPreds) | ||
| assert(metrics.explainedVarianceScore() ~== 0.95717 absTol 1E-5,"explained variance regression score mismatch") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line to wide |
||
| assert(metrics.mae() ~== 0.5 absTol 1E-5, "mean absolute error mismatch") | ||
| assert(metrics.mse() ~== 0.375 absTol 1E-5, "mean square error mismatch") | ||
| assert(metrics.r2_score() ~== 0.94861 absTol 1E-5, "r2 score mismatch") | ||
| } | ||
|
|
||
| test("regression metrics with complete fitting") { | ||
| val valuesAndPreds = sc.parallelize( | ||
| Seq((3.0,3.0),(0.0,0.0),(2.0,2.0),(8.0,8.0)),2) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. space after |
||
| val metrics = new RegressionMetrics(valuesAndPreds) | ||
| assert(metrics.explainedVarianceScore() ~== 1.0 absTol 1E-5,"explained variance regression score mismatch") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line too wide |
||
| assert(metrics.mae() ~== 0.0 absTol 1E-5, "mean absolute error mismatch") | ||
| assert(metrics.mse() ~== 0.0 absTol 1E-5, "mean square error mismatch") | ||
| assert(metrics.r2_score() ~== 1.0 absTol 1E-5, "r2 score mismatch") | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with other evaluation metrics, let's put the prediction as the first column. The word
valueis vague. We can usepredictionAndObservationsinstead. Note that there nosafterpredictionto indicator that this is an RDD of pairs instead of a pair of RDDs.