Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.mllib.evaluation

import org.apache.spark.annotation.Experimental
import org.apache.spark.rdd.RDD
import org.apache.spark.Logging
import org.apache.spark.mllib.linalg.Vectors
import org.apache.spark.mllib.stat.MultivariateOnlineSummarizer
import org.apache.spark.mllib.rdd.RDDFunctions._

/**
* :: Experimental ::
* Evaluator for regression.
*
* @param valuesAndPreds an RDD of (value, pred) pairs.
*/
@Experimental
class RegressionMetrics(valuesAndPreds: RDD[(Double, Double)]) extends Logging {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with other evaluation metrics, let's put the prediction as the first column. The word value is vague. We can use predictionAndObservations instead. Note that there no s after prediction to indicator that this is an RDD of pairs instead of a pair of RDDs.


/**
* Use MultivariateOnlineSummarizer to calculate mean and variance of different combination.
* MultivariateOnlineSummarizer is a numerically stable algorithm to compute mean and variance
* in a online fashion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence is not necessary, which is the doc for MOS but not summarizer. The first sentence can be changed to

Use MultivariateOnlineSummarizer to calculate summary statistics of observations and errors.

*/
private lazy val summarizer: MultivariateOnlineSummarizer = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: I would recommend renaming summarizer to summary: MultivariateStatisticalSummary, because it is static after.

val summarizer: MultivariateOnlineSummarizer = valuesAndPreds.map{
case (value,pred) => Vectors.dense(
Array(value, value - pred, math.abs(value - pred), math.pow(value - pred, 2.0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also picky but you can avoid math.pow and avoid computing value - pred 3 times here with a local var. Might be cleaner. This LGTM for what it's worth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third and the forth columns are not necessary. You can use normL1 and normL2 on the second column:

https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala#L219

)
}.treeAggregate(new MultivariateOnlineSummarizer())(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: treeAggregate doesn't help much here because the data is really small.

(summary, v) => summary.add(v),
(sum1,sum2) => sum1.merge(sum2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after ,

)
summarizer
}

/**
* Computes the explained variance regression score
*/
def explainedVarianceScore(): Double = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a quite minor point, you might want to remove the (), as these methods do not have side-effect (like Array.length). Same for the other methods.

1 - summarizer.variance(1) / summarizer.variance(0)
}

/**
* Computes the mean absolute error, which is a risk function corresponding to the
* expected value of the absolute error loss or l1-norm loss.
*/
def mae(): Double = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on @srowen 's suggestion mae -> meanAbsoluteError

summarizer.mean(2)
}

/**
* Computes the mean square error, which is a risk function corresponding to the
* expected value of the squared error loss or quadratic loss.
*/
def mse(): Double = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mse -> meanSquaredError

I recommend adding rootMeanSquareError. Though it is trivial to get from MSE, it is widely used.

summarizer.mean(3)
}

/**
* Computes R^2^, the coefficient of determination.
* @return
*/
def r2_score(): Double = {
1 - summarizer.mean(3) * summarizer.count / (summarizer.variance(0) * (summarizer.count - 1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be worth a comment to explain what sums of squares you are trying to compute in the numerator and denominator. A link to the definition might be good, here and for explained variance, since they are related.

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.mllib.evaluation

import org.scalatest.FunSuite
import org.apache.spark.mllib.util.LocalSparkContext
import org.apache.spark.mllib.util.TestingUtils._

class RegressionMetricsSuite extends FunSuite with LocalSparkContext {

test("regression metrics") {
val valuesAndPreds = sc.parallelize(
Seq((3.0,2.5),(-0.5,0.0),(2.0,2.0),(7.0,8.0)),2)
val metrics = new RegressionMetrics(valuesAndPreds)
assert(metrics.explainedVarianceScore() ~== 0.95717 absTol 1E-5,"explained variance regression score mismatch")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line to wide

assert(metrics.mae() ~== 0.5 absTol 1E-5, "mean absolute error mismatch")
assert(metrics.mse() ~== 0.375 absTol 1E-5, "mean square error mismatch")
assert(metrics.r2_score() ~== 0.94861 absTol 1E-5, "r2 score mismatch")
}

test("regression metrics with complete fitting") {
val valuesAndPreds = sc.parallelize(
Seq((3.0,3.0),(0.0,0.0),(2.0,2.0),(8.0,8.0)),2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after ,

val metrics = new RegressionMetrics(valuesAndPreds)
assert(metrics.explainedVarianceScore() ~== 1.0 absTol 1E-5,"explained variance regression score mismatch")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too wide

assert(metrics.mae() ~== 0.0 absTol 1E-5, "mean absolute error mismatch")
assert(metrics.mse() ~== 0.0 absTol 1E-5, "mean square error mismatch")
assert(metrics.r2_score() ~== 1.0 absTol 1E-5, "r2 score mismatch")
}
}