-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-4111 [MLlib] add regression metrics #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43bb12b
add regression metrics
2e56282
rename r2_score() and remove unused column
d454909
rename parameter and function names, delete unused columns, add refer…
a8ad3e3
simplify code for keeping style
3d0bec1
rename and keep code style
730d0a9
more clearly annotation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
89 changes: 89 additions & 0 deletions
89
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.mllib.evaluation | ||
|
|
||
| import org.apache.spark.annotation.Experimental | ||
| import org.apache.spark.rdd.RDD | ||
| import org.apache.spark.Logging | ||
| import org.apache.spark.mllib.linalg.Vectors | ||
| import org.apache.spark.mllib.stat.{MultivariateStatisticalSummary, MultivariateOnlineSummarizer} | ||
|
|
||
| /** | ||
| * :: Experimental :: | ||
| * Evaluator for regression. | ||
| * | ||
| * @param predictionAndObservations an RDD of (prediction, observation) pairs. | ||
| */ | ||
| @Experimental | ||
| class RegressionMetrics(predictionAndObservations: RDD[(Double, Double)]) extends Logging { | ||
|
|
||
| /** | ||
| * Use MultivariateOnlineSummarizer to calculate summary statistics of observations and errors. | ||
| */ | ||
| private lazy val summary: MultivariateStatisticalSummary = { | ||
| val summary: MultivariateStatisticalSummary = predictionAndObservations.map { | ||
| case (prediction, observation) => Vectors.dense(observation, observation - prediction) | ||
| }.aggregate(new MultivariateOnlineSummarizer())( | ||
| (summary, v) => summary.add(v), | ||
| (sum1, sum2) => sum1.merge(sum2) | ||
| ) | ||
| summary | ||
| } | ||
|
|
||
| /** | ||
| * Returns the explained variance regression score. | ||
| * explainedVariance = 1 - variance(y - \hat{y}) / variance(y) | ||
| * Reference: [[http://en.wikipedia.org/wiki/Explained_variation]] | ||
| */ | ||
| def explainedVariance: Double = { | ||
| 1 - summary.variance(1) / summary.variance(0) | ||
| } | ||
|
|
||
| /** | ||
| * Returns the mean absolute error, which is a risk function corresponding to the | ||
| * expected value of the absolute error loss or l1-norm loss. | ||
| */ | ||
| def meanAbsoluteError: Double = { | ||
| summary.normL1(1) / summary.count | ||
| } | ||
|
|
||
| /** | ||
| * Returns the mean squared error, which is a risk function corresponding to the | ||
| * expected value of the squared error loss or quadratic loss. | ||
| */ | ||
| def meanSquaredError: Double = { | ||
| val rmse = summary.normL2(1) / math.sqrt(summary.count) | ||
| rmse * rmse | ||
| } | ||
|
|
||
| /** | ||
| * Returns the root mean squared error, which is defined as the square root of | ||
| * the mean squared error. | ||
| */ | ||
| def rootMeanSquaredError: Double = { | ||
| summary.normL2(1) / math.sqrt(summary.count) | ||
| } | ||
|
|
||
| /** | ||
| * Returns R^2^, the coefficient of determination. | ||
| * Reference: [[http://en.wikipedia.org/wiki/Coefficient_of_determination]] | ||
| */ | ||
| def r2: Double = { | ||
| 1 - math.pow(summary.normL2(1), 2) / (summary.variance(0) * (summary.count - 1)) | ||
| } | ||
| } | ||
52 changes: 52 additions & 0 deletions
52
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.mllib.evaluation | ||
|
|
||
| import org.scalatest.FunSuite | ||
|
|
||
| import org.apache.spark.mllib.util.LocalSparkContext | ||
| import org.apache.spark.mllib.util.TestingUtils._ | ||
|
|
||
| class RegressionMetricsSuite extends FunSuite with LocalSparkContext { | ||
|
|
||
| test("regression metrics") { | ||
| val predictionAndObservations = sc.parallelize( | ||
| Seq((2.5,3.0),(0.0,-0.5),(2.0,2.0),(8.0,7.0)), 2) | ||
| val metrics = new RegressionMetrics(predictionAndObservations) | ||
| assert(metrics.explainedVariance ~== 0.95717 absTol 1E-5, | ||
| "explained variance regression score mismatch") | ||
| assert(metrics.meanAbsoluteError ~== 0.5 absTol 1E-5, "mean absolute error mismatch") | ||
| assert(metrics.meanSquaredError ~== 0.375 absTol 1E-5, "mean squared error mismatch") | ||
| assert(metrics.rootMeanSquaredError ~== 0.61237 absTol 1E-5, | ||
| "root mean squared error mismatch") | ||
| assert(metrics.r2 ~== 0.94861 absTol 1E-5, "r2 score mismatch") | ||
| } | ||
|
|
||
| test("regression metrics with complete fitting") { | ||
| val predictionAndObservations = sc.parallelize( | ||
| Seq((3.0,3.0),(0.0,0.0),(2.0,2.0),(8.0,8.0)), 2) | ||
| val metrics = new RegressionMetrics(predictionAndObservations) | ||
| assert(metrics.explainedVariance ~== 1.0 absTol 1E-5, | ||
| "explained variance regression score mismatch") | ||
| assert(metrics.meanAbsoluteError ~== 0.0 absTol 1E-5, "mean absolute error mismatch") | ||
| assert(metrics.meanSquaredError ~== 0.0 absTol 1E-5, "mean squared error mismatch") | ||
| assert(metrics.rootMeanSquaredError ~== 0.0 absTol 1E-5, | ||
| "root mean squared error mismatch") | ||
| assert(metrics.r2 ~== 1.0 absTol 1E-5, "r2 score mismatch") | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space after
,