Skip to content

[SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Fix Python lint issue #29733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunchao wants to merge 1 commit into from
Closed

[SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Fix Python lint issue #29733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/docs/source/getting_started/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Note that `PySpark at Conda <https://anaconda.org/conda-forge/pyspark>`_ is avai
Official Release Channel
------------------------

Different flavors of PySpark is available in the `official release channel <https://spark.apache.org/downloads.html>`_.
Different flavors of PySpark is available in the `official release channel <https://spark.apache.org/downloads.html>`__.
Copy link
Member

@srowen srowen Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? the link below depends on this anchor.
(We can fix is -> are too)

Copy link
Member

@srowen srowen Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #29735 for an alternative

Copy link
Member Author

@sunchao sunchao Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only compared the result html file and the diff is (rhs is old):

435a436,438
> <div class="system-message">
> <p class="system-message-title">System Message: WARNING/2 (<tt class="docutils">python/docs/source/getting_started/installation.rst</tt>, line 20); <em><a href="#id3">backlink</a></em></p>
> Duplicate explicit target name: &quot;official release channel&quot;.</div>

which seems OK.

Sure I'll abandon this PR since you have better knowledge on this :)

Any suitable version can be downloaded and extracted as below:

.. code-block:: bash
Expand All @@ -97,7 +97,7 @@ Installing from Source

To install PySpark from source, refer to `Building Spark <https://spark.apache.org/docs/latest/building-spark.html>`_.

Refer to `Official Release Channel <#official-release-channel>`_ for steps to define ``PYTHONPATH``.
Refer to `Official Release Channel <#official-release-channel>`__ for steps to define ``PYTHONPATH``.

Dependencies
------------
Expand All @@ -111,4 +111,4 @@ Package Minimum supported version Note
============= ========================= ================

**Note**: PySpark requires Java 8 or later with ``JAVA_HOME`` properly set.
If using JDK 11, set ``-Dio.netty.tryReflectionSetAccessible=true`` for Arrow related features and refer to `Downloading <https://spark.apache.org/docs/latest/#downloading>`_
If using JDK 11, set ``-Dio.netty.tryReflectionSetAccessible=true`` for Arrow related features and refer to `Downloading <https://spark.apache.org/docs/latest/#downloading>`_