Skip to content

Conversation

@sunchao
Copy link
Member

@sunchao sunchao commented Sep 12, 2020

What changes were proposed in this pull request?

Seems #29640 introduced a Python lint error:

Warning, treated as error:
/home/runner/work/spark/spark/python/docs/source/getting_started/installation.rst:20:Duplicate explicit target name: "official release channel".
Makefile:20: recipe for target 'html' failed
make: *** [html] Error 2

This tries to fix it.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@sunchao
Copy link
Member Author

sunchao commented Sep 12, 2020

cc @srowen

------------------------

Different flavors of PySpark is available in the `official release channel <https://spark.apache.org/downloads.html>`_.
Different flavors of PySpark is available in the `official release channel <https://spark.apache.org/downloads.html>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? the link below depends on this anchor.
(We can fix is -> are too)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #29735 for an alternative

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only compared the result html file and the diff is (rhs is old):

435a436,438
> <div class="system-message">
> <p class="system-message-title">System Message: WARNING/2 (<tt class="docutils">python/docs/source/getting_started/installation.rst</tt>, line 20); <em><a href="#id3">backlink</a></em></p>
> Duplicate explicit target name: &quot;official release channel&quot;.</div>

which seems OK.

Sure I'll abandon this PR since you have better knowledge on this :)

@sunchao sunchao closed this Sep 12, 2020
@SparkQA
Copy link

SparkQA commented Sep 12, 2020

Test build #128583 has finished for PR 29733 at commit e32f85f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants