[SPARK-32160][CORE][PYSPARK][3.0] Add a config to switch allow/disallow to create SparkContext in executors. #29294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #126794 has finished for PR 29294 at commit
|
ueshin
changed the title
|
Test build #126809 has finished for PR 29294 at commit
|
Member
Author
|
Jenkins, retest this please. |
|
Test build #126833 has finished for PR 29294 at commit
|
Member
Author
|
Jenkins, retest this please. |
HyukjinKwon
approved these changes
Jul 31, 2020
|
Test build #126861 has finished for PR 29294 at commit
|
Member
|
retest this please |
1 similar comment
Member
|
retest this please |
|
Test build #126885 has finished for PR 29294 at commit
|
Member
|
Merged to branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 3, 2020
…ow to create SparkContext in executors ### What changes were proposed in this pull request? This is a backport of #29278, but with allowing to create `SparkContext` in executors by default. This PR adds a config to switch allow/disallow to create `SparkContext` in executors. - `spark.driver.allowSparkContextInExecutors` ### Why are the changes needed? Some users or libraries actually create `SparkContext` in executors. We shouldn't break their workloads. ### Does this PR introduce _any_ user-facing change? Yes, users will be able to disallow to create `SparkContext` in executors with the config disabled. ### How was this patch tested? More tests are added. Closes #29294 from ueshin/issues/SPARK-32160/3.0/add_configs. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Member
|
For the configuration namespace, I have a question about that. Please see the original PR. |
Member
|
Yeah, it makes sense. Thanks for pointing that out. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 4, 2020
… switch allow/disallow SparkContext in executors ### What changes were proposed in this pull request? This is a follow-up of #29294. This PR changes the config name to switch allow/disallow `SparkContext` in executors as per the comment #29278 (review). ### Why are the changes needed? The config name `spark.executor.allowSparkContext` is more reasonable. ### Does this PR introduce _any_ user-facing change? Yes, the config name is changed. ### How was this patch tested? Updated tests. Closes #29341 from ueshin/issues/SPARK-32160/3.0/change_config_name. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a backport of #29278, but with allowing to create
SparkContextin executors by default.This PR adds a config to switch allow/disallow to create
SparkContextin executors.spark.driver.allowSparkContextInExecutorsWhy are the changes needed?
Some users or libraries actually create
SparkContextin executors.We shouldn't break their workloads.
Does this PR introduce any user-facing change?
Yes, users will be able to disallow to create
SparkContextin executors with the config disabled.How was this patch tested?
More tests are added.