Skip to content

[SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name #29279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
venkata91 wants to merge 2 commits into from
Closed

[SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name #29279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e22c5
[SPARK-31418][FOLLOW-UP][MINOR] Fix log messages to print stage id in…
venkata91 Jul 29, 2020
ad847b1
Addressed maropu review comment
venkata91 Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,16 +662,17 @@ private[spark] class TaskSchedulerImpl(
// in order to provision more executors to make them schedulable
if (Utils.isDynamicAllocationEnabled(conf)) {
if (!unschedulableTaskSetToExpiryTime.contains(taskSet)) {
logInfo(s"Notifying ExecutorAllocationManager to allocate more executors to" +
s" schedule the unschedulable task before aborting $taskSet.")
logInfo("Notifying ExecutorAllocationManager to allocate more executors to" +
" schedule the unschedulable task before aborting" +
" stage ${taskSet.stageId}.")
dagScheduler.unschedulableTaskSetAdded(taskSet.taskSet.stageId,
taskSet.taskSet.stageAttemptId)
updateUnschedulableTaskSetTimeoutAndStartAbortTimer(taskSet, taskIndex)
}
} else {
// Abort Immediately
logInfo("Cannot schedule any task because of complete blacklisting. No idle" +
s" executors can be found to kill. Aborting $taskSet.")
s" executors can be found to kill. Aborting stage ${taskSet.stageId}.")
taskSet.abortSinceCompletelyBlacklisted(taskIndex)
}
}
Expand Down Expand Up @@ -742,7 +743,7 @@ private[spark] class TaskSchedulerImpl(
val timeout = conf.get(config.UNSCHEDULABLE_TASKSET_TIMEOUT) * 1000
unschedulableTaskSetToExpiryTime(taskSet) = clock.getTimeMillis() + timeout
logInfo(s"Waiting for $timeout ms for completely " +
s"blacklisted task to be schedulable again before aborting $taskSet.")
s"blacklisted task to be schedulable again before aborting stage ${taskSet.stageId}.")
abortTimer.schedule(
createUnschedulableTaskSetAbortTimer(taskSet, taskIndex), timeout)
}
Expand All @@ -755,7 +756,7 @@ private[spark] class TaskSchedulerImpl(
if (unschedulableTaskSetToExpiryTime.contains(taskSet) &&
unschedulableTaskSetToExpiryTime(taskSet) <= clock.getTimeMillis()) {
logInfo("Cannot schedule any task because of complete blacklisting. " +
s"Wait time for scheduling expired. Aborting $taskSet.")
s"Wait time for scheduling expired. Aborting stage ${taskSet.stageId}.")
taskSet.abortSinceCompletelyBlacklisted(taskIndex)
} else {
this.cancel()
Expand Down