-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31418][CORE][FOLLOW-UP][MINOR] Fix log messages to print stage id instead of the object name #29279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…stead of the object name
|
@tgravescs This is just a minor log line changes which I found printing object names instead of the IDs. |
|
ok to test |
|
what did the log look like before? I thought printing the taskSet should give you something like: TaskSet 2.0. where 2 is the stage id and 0 is the stage attempt id. Now its only printing the stage id without the attempt id? |
|
Test build #126776 has finished for PR 29279 at commit
|
|
Infact its not even printing stageId rather printing the TaskSetManager object name. Do you think instead of printing stageId its better to print name For eg: |
|
what if you explicitly put ${taskSet.toString} |
|
oh sorry, I was looking at the wrong thing, those are TaskSetManagers not TaskSet |
Yes thats right. Do you think its better to add I think
With stageId: |
|
no, I think this is fine. |
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
Outdated
Show resolved
Hide resolved
|
Test build #126811 has finished for PR 29279 at commit
|
|
retest this please |
|
Test build #126848 has finished for PR 29279 at commit
|
|
retest this please |
|
Test build #126873 has finished for PR 29279 at commit
|
|
Merged to master. |
What changes were proposed in this pull request?
Just few log lines fixes which are logging the object name instead of the stage IDs
Why are the changes needed?
This would make it easier later for debugging.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just log messages. Existing tests should be enough