[SPARK-32311][PYSPARK][TESTS] Remove duplicate import #29109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime is already imported a few lines below
|
Can one of the admins verify this patch? |
Contributor
Author
|
cc @HyukjinKwon |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jul 14, 2020
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @Fokko .
Merged to master for Apache Spark 3.1.0 on December 2020.
GitHub Action passed.
Contributor
Author
|
Thanks for picking this up so quickly @dongjoon-hyun |
Member
|
I assume you cought these by a linter? Let's fix them together in batch next time. |
Member
|
@HyukjinKwon . I asked the same question #29109 (comment) . |
Member
|
Oh, I meant this and #29108. But okay I can see these PR could be separate in a way. Thanks guys. |
Contributor
Author
|
These PR's are a bit small indeed, but there are a few coming up that are much bigger. I would like to split them a bit to make it easier to digest for the reviewers/committers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
datetimeis already imported a few lines below :)spark/python/pyspark/sql/tests/test_pandas_udf_scalar.py
Line 24 in ce27cc5
Why are the changes needed?
This is the last instance of the duplicate import.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.