[SPARK-32309][PYSPARK] Import missing sys import #29108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
SPARK-32309
branch
2 times, most recently
from
2ad7314 to
92ab5a7
Compare
|
Can one of the admins verify this patch? |
The import is used a few line below
Contributor
Author
|
cc @HyukjinKwon |
dongjoon-hyun
approved these changes
Jul 14, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @Fokko .
Merged to master. The GitHub Action passed.
Member
|
Thanks @Fokko and @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While seeing if we can use mypy for checking the Python types, I've stumbled across this missing import:
spark/python/pyspark/ml/feature.py
Lines 5773 to 5774 in 34fa913
Why are the changes needed?
The
importis required because it's used.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.