[SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package #28790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sql.execution package
Contributor
Author
|
cc. @HyukjinKwon |
HyukjinKwon
approved these changes
Jun 11, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM, thanks @HeartSaVioR.
cloud-fan
approved these changes
Jun 11, 2020
|
Test build #123787 has finished for PR 28790 at commit
|
Contributor
Author
|
retest this, please |
Member
|
Made a PR for #28790 (comment), #28798 |
dongjoon-hyun
approved these changes
Jun 11, 2020
Member
|
Since this is not related to UT running, merged to master/3.0. Thank you all. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 11, 2020
… sql.execution package ### What changes were proposed in this pull request? This PR proposes to remove package private in classes/objects in sql.execution package, as per SPARK-16964. ### Why are the changes needed? This is per post-hoc review comment, see #24996 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes #28790 from HeartSaVioR/SPARK-28199-FOLLOWUP-apply-SPARK-16964. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4afe2b1) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Test build #123815 has finished for PR 28790 at commit
|
Contributor
Author
|
Thanks all for reviewing and merging! |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jun 25, 2020
… sql.execution package ### What changes were proposed in this pull request? This PR proposes to remove package private in classes/objects in sql.execution package, as per SPARK-16964. ### Why are the changes needed? This is per post-hoc review comment, see apache#24996 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes apache#28790 from HeartSaVioR/SPARK-28199-FOLLOWUP-apply-SPARK-16964. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4afe2b1) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to remove package private in classes/objects in sql.execution package, as per SPARK-16964.
Why are the changes needed?
This is per post-hoc review comment, see #24996 (comment)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A