Skip to content

[SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier #28726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhulipeng wants to merge 1 commit into from
Closed

[SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier #28726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ trait NamedExpression extends Expression {
* e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation.
* 2. Seq with a Single element: either the table name or the alias name of the table.
* 3. Seq with 2 elements: database name and table name
* 4. Seq with 3 elements: catalog name, database name and table name
Copy link
Member

@maropu maropu Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace instead?

Copy link
Contributor Author

@zhulipeng zhulipeng Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace instead?

Sorry for the late response. You mean catalog namespace?

Copy link
Member

@HyukjinKwon HyukjinKwon Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he meant to document the namespace support in catalogV2, which is related but I think can be done separately.

Copy link
Member

@maropu maropu Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it looks fine as it is.

*/
def qualifier: Seq[String]

Expand Down