[SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier#28726
Closed
zhulipeng wants to merge 1 commit intoapache:masterfrom
zhulipeng:SPARK-31906
Closed
[SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier#28726zhulipeng wants to merge 1 commit intoapache:masterfrom zhulipeng:SPARK-31906
zhulipeng wants to merge 1 commit intoapache:masterfrom
zhulipeng:SPARK-31906
Conversation
HyukjinKwon
changed the title
Member
|
ok to test |
Member
|
Seems fine, cc @cloud-fan FYI |
|
Test build #123568 has finished for PR 28726 at commit
|
maropu
reviewed
Jun 5, 2020
| * e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation. | ||
| * 2. Seq with a Single element: either the table name or the alias name of the table. | ||
| * 3. Seq with 2 elements: database name and table name | ||
| * 4. Seq with 3 elements: catalog name, database name and table name |
Contributor
Author
There was a problem hiding this comment.
namespace instead?
Sorry for the late response. You mean catalog namespace?
Member
There was a problem hiding this comment.
I think he meant to document the namespace support in catalogV2, which is related but I think can be done separately.
HyukjinKwon
approved these changes
Jun 9, 2020
maropu
approved these changes
Jun 9, 2020
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The qualifier name should contains catalog name.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
UT.