[SPARK-31888][SQL] Support java.time.Instant in Parquet filter pushdown
#28696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The changes are similar to #28259. @cloud-fan @HyukjinKwon Please, review this PR. |
|
Test build #123385 has finished for PR 28696 at commit
|
HyukjinKwon
approved these changes
Jun 2, 2020
cloud-fan
reviewed
Jun 2, 2020
...e/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #123420 has finished for PR 28696 at commit
|
Member
Author
|
jenkins, retest this, please |
|
Test build #123422 has finished for PR 28696 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 2, 2020
…down 1. Modified `ParquetFilters.valueCanMakeFilterOn()` to accept filters with `java.time.Instant` attributes. 2. Added `ParquetFilters.timestampToMicros()` to support both types `java.sql.Timestamp` and `java.time.Instant` in conversions to microseconds. 3. Re-used `timestampToMicros` in constructing of Parquet filters. To support pushed down filters with `java.time.Instant` attributes. Before the changes, date filters are not pushed down to Parquet datasource when `spark.sql.datetime.java8API.enabled` is `true`. No Modified tests to `ParquetFilterSuite` to check the case when Java 8 API is enabled. Closes #28696 from MaxGekk/support-instant-parquet-filters. Authored-by: Max Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ParquetFilters.valueCanMakeFilterOn()to accept filters withjava.time.Instantattributes.ParquetFilters.timestampToMicros()to support both typesjava.sql.Timestampandjava.time.Instantin conversions to microseconds.timestampToMicrosin constructing of Parquet filters.Why are the changes needed?
To support pushed down filters with
java.time.Instantattributes. Before the changes, date filters are not pushed down to Parquet datasource whenspark.sql.datetime.java8API.enabledistrue.Does this PR introduce any user-facing change?
No
How was this patch tested?
Modified tests to
ParquetFilterSuiteto check the case when Java 8 API is enabled.