[SPARK-31488][SQL] Support java.time.LocalDate in Parquet filter pushdown
#28259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #121479 has finished for PR 28259 at commit
|
Member
Author
|
@cloud-fan @HyukjinKwon Please, review the PR. |
Contributor
|
We don't need to fix parquet if we follow #28261 (comment) |
Member
Author
|
jenkins, retest this, please |
…ter-java8-date-time
|
Test build #121687 has finished for PR 28259 at commit
|
|
Test build #121695 has finished for PR 28259 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 24, 2020
…shdown ### What changes were proposed in this pull request? 1. Modified `ParquetFilters.valueCanMakeFilterOn()` to accept filters with `java.time.LocalDate` attributes. 2. Modified `ParquetFilters.dateToDays()` to support both types `java.sql.Date` and `java.time.LocalDate` in conversions to days. 3. Add implicit conversion from `LocalDate` to `Expression` (`Literal`). ### Why are the changes needed? To support pushed down filters with `java.time.LocalDate` attributes. Before the changes, date filters are not pushed down to Parquet datasource when `spark.sql.datetime.java8API.enabled` is `true`. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Added a test to `ParquetFilterSuite` Closes #28259 from MaxGekk/parquet-filter-java8-date-time. Authored-by: Max Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 2616542) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ParquetFilters.valueCanMakeFilterOn()to accept filters withjava.time.LocalDateattributes.ParquetFilters.dateToDays()to support both typesjava.sql.Dateandjava.time.LocalDatein conversions to days.LocalDatetoExpression(Literal).Why are the changes needed?
To support pushed down filters with
java.time.LocalDateattributes. Before the changes, date filters are not pushed down to Parquet datasource whenspark.sql.datetime.java8API.enabledistrue.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test to
ParquetFilterSuite