Skip to content

[SPARK-31835][SQL][TESTS] Add zoneId to codegen related tests in DateExpressionsSuite #28653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-31835][SQL][TESTS] Add zoneId to codegen related tests in DateExpressionsSuite #28653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eea688
[SPARK-31835][SQL][TESTS] Add zoneId to codegen related test in DateE…
yaooqinn May 27, 2020
db92498
utc
yaooqinn May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
}
// Test escaping of format
GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote")) :: Nil)
GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote"), JST_OPT) :: Nil)

@cloud-fan cloud-fan May 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the timezone doesn't matter, shall we use UTC?

@MaxGekk MaxGekk May 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Particular time zone doesn't matter here, we just check that codegen doesn't throw any exception.

}

test("unix_timestamp") {
Expand Down Expand Up @@ -862,7 +862,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
// Test escaping of format
GenerateUnsafeProjection.generate(
UnixTimestamp(Literal("2015-07-24"), Literal("\"quote")) :: Nil)
UnixTimestamp(Literal("2015-07-24"), Literal("\"quote"), JST_OPT) :: Nil)
}

test("to_unix_timestamp") {
Expand Down Expand Up @@ -940,7 +940,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
// Test escaping of format
GenerateUnsafeProjection.generate(
ToUnixTimestamp(Literal("2015-07-24"), Literal("\"quote")) :: Nil)
ToUnixTimestamp(Literal("2015-07-24"), Literal("\"quote"), JST_OPT) :: Nil)
}

test("datediff") {
Expand Down