[SPARK-31835][SQL][TESTS] Add zoneId to codegen related tests in DateExpressionsSuite #28653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
changed the title
Member
Author
|
cc @cloud-fan @MaxGekk thanks very much. |
cloud-fan
reviewed
May 27, 2020
| } | ||
| // Test escaping of format | ||
| GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote")) :: Nil) | ||
| GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote"), JST_OPT) :: Nil) |
Contributor
There was a problem hiding this comment.
if the timezone doesn't matter, shall we use UTC?
Member
There was a problem hiding this comment.
Particular time zone doesn't matter here, we just check that codegen doesn't throw any exception.
MaxGekk
approved these changes
May 27, 2020
| } | ||
| // Test escaping of format | ||
| GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote")) :: Nil) | ||
| GenerateUnsafeProjection.generate(FromUnixTime(Literal(0L), Literal("\"quote"), JST_OPT) :: Nil) |
Member
There was a problem hiding this comment.
Particular time zone doesn't matter here, we just check that codegen doesn't throw any exception.
|
Test build #123178 has finished for PR 28653 at commit
|
|
Test build #123186 has finished for PR 28653 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
May 27, 2020
…ExpressionsSuite ### What changes were proposed in this pull request? This PR modifies some codegen related tests to test escape characters for datetime functions which are time zone aware. If the timezone is absent, the formatter could result in `null` caused by `java.util.NoSuchElementException: None.get` and bypassing the real intention of those test cases. ### Why are the changes needed? fix tests ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? passing the modified test cases. Closes #28653 from yaooqinn/SPARK-31835. Authored-by: Kent Yao <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 311fe6a) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies some codegen related tests to test escape characters for datetime functions which are time zone aware. If the timezone is absent, the formatter could result in
nullcaused byjava.util.NoSuchElementException: None.getand bypassing the real intention of those test cases.Why are the changes needed?
fix tests
Does this PR introduce any user-facing change?
no
How was this patch tested?
passing the modified test cases.