Skip to content

[SPARK-30667][FOLLOW-UP][CORE] Change BarrierTaskContext allGather method return type #27951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarthfrey wants to merge 1 commit into from
Closed

[SPARK-30667][FOLLOW-UP][CORE] Change BarrierTaskContext allGather method return type #27951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/BarrierTaskContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ class BarrierTaskContext private[spark] (
*/
@Experimental
@Since("3.0.0")
def allGather(message: String): ArrayBuffer[String] = {
def allGather(message: String): Array[String] = {
val json = runBarrier(RequestMethod.ALL_GATHER, message)
val jsonArray = parse(json)
implicit val formats = DefaultFormats
ArrayBuffer(jsonArray.extract[Array[String]]: _*)
jsonArray.extract[Array[String]]
}

/**
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
context.asInstanceOf[BarrierTaskContext].barrier()
result = BarrierTaskContextMessageProtocol.BARRIER_RESULT_SUCCESS
case BarrierTaskContextMessageProtocol.ALL_GATHER_FUNCTION =>
val messages: ArrayBuffer[String] = context.asInstanceOf[BarrierTaskContext].allGather(
val messages: Array[String] = context.asInstanceOf[BarrierTaskContext].allGather(
Copy link
Member

@srowen srowen Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't even need these types here and below, but it won't matter

message
)
result = compact(render(JArray(
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class BarrierTaskContextSuite extends SparkFunSuite with LocalSparkContext {
Thread.sleep(Random.nextInt(1000))
// Pass partitionId message in
val message: String = context.partitionId().toString
val messages: ArrayBuffer[String] = context.allGather(message)
val messages: Array[String] = context.allGather(message)
messages.toList.iterator
}
// Take a sorted list of all the partitionId messages
Expand Down