[SPARK-30667][FOLLOW-UP][CORE] Change BarrierTaskContext allGather method return type#27951
Closed
sarthfrey wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30667][FOLLOW-UP][CORE] Change BarrierTaskContext allGather method return type#27951sarthfrey wants to merge 1 commit intoapache:masterfrom
sarthfrey wants to merge 1 commit intoapache:masterfrom
Conversation
srowen
approved these changes
Mar 18, 2020
| result = BarrierTaskContextMessageProtocol.BARRIER_RESULT_SUCCESS | ||
| case BarrierTaskContextMessageProtocol.ALL_GATHER_FUNCTION => | ||
| val messages: ArrayBuffer[String] = context.asInstanceOf[BarrierTaskContext].allGather( | ||
| val messages: Array[String] = context.asInstanceOf[BarrierTaskContext].allGather( |
Member
There was a problem hiding this comment.
You probably don't even need these types here and below, but it won't matter
mengxr
approved these changes
Mar 18, 2020
|
Test build #120000 has finished for PR 27951 at commit
|
dongjoon-hyun
approved these changes
Mar 18, 2020
HyukjinKwon
approved these changes
Mar 19, 2020
zhengruifeng
approved these changes
Mar 19, 2020
HyukjinKwon
changed the title
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 19, 2020
… type This PR proposes that we change the return type of the `BarrierTaskContext.allGather` method to `Array[String]` instead of `ArrayBuffer[String]` since it is immutable. Based on discussion in #27640. cc zhengruifeng srowen Closes #27951 from sarthfrey/all-gather-api. Authored-by: sarthfrey-db <sarth.frey@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 6fd3138) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
|
Merged to master and branch-3.0. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… type This PR proposes that we change the return type of the `BarrierTaskContext.allGather` method to `Array[String]` instead of `ArrayBuffer[String]` since it is immutable. Based on discussion in apache#27640. cc zhengruifeng srowen Closes apache#27951 from sarthfrey/all-gather-api. Authored-by: sarthfrey-db <sarth.frey@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes that we change the return type of the
BarrierTaskContext.allGathermethod toArray[String]instead ofArrayBuffer[String]since it is immutable. Based on discussion in #27640. cc @zhengruifeng @srowen