[SPARK-30547][SQL][FOLLOWUP] Update since anotation for CalendarInterval class#27299
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-30547-F
Closed
[SPARK-30547][SQL][FOLLOWUP] Update since anotation for CalendarInterval class#27299yaooqinn wants to merge 1 commit intoapache:masterfrom yaooqinn:SPARK-30547-F
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-30547-F
Conversation
cloud-fan
approved these changes
Jan 21, 2020
HyukjinKwon
approved these changes
Jan 21, 2020
dongjoon-hyun
approved these changes
Jan 21, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for the follow-up.
|
Test build #117145 has finished for PR 27299 at commit
|
Member
Author
|
retest this please |
|
Test build #117170 has finished for PR 27299 at commit
|
Contributor
|
thanks, merging to master! |
HyukjinKwon
reviewed
Jan 31, 2020
| * @since 1.5.0 | ||
| * @since 3.0.0 | ||
| */ | ||
| @Unstable |
Member
There was a problem hiding this comment.
BTW, are we going to expose this as an API? Technically, this is under internal package which isn't documented:
https://github.com/apache/spark/blob/master/project/SparkBuild.scala#L828
Member
There was a problem hiding this comment.
Let me open a PR after a quick test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Mark
CalendarIntervalclass withsince 3.0.0.Why are the changes needed?
https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since
This class is the first time going to the public, the annotation is the first time to add, and we don't want people to get confused and try to use it 2.4.x.
Does this PR introduce any user-facing change?
no
How was this patch tested?
no