[SPARK-30547][SQL] Add unstable annotation to the CalendarInterval class#27258
[SPARK-30547][SQL] Add unstable annotation to the CalendarInterval class#27258yaooqinn wants to merge 3 commits intoapache:masterfrom yaooqinn:SPARK-30547
Conversation
|
Test build #116922 has finished for PR 27258 at commit
|
|
|
||
| /** | ||
| * The internal representation of interval type. | ||
| * The data type representing calendar intervals. The calendar interval is stored internally in |
There was a problem hiding this comment.
data type? how about The class representing ...
|
Test build #116941 has finished for PR 27258 at commit
|
|
Test build #116997 has finished for PR 27258 at commit
|
|
thanks, merging to master! |
| * they are two separated fields from microseconds. One month may be equal to 28, 29, 30 or 31 days | ||
| * and one day may be equal to 23, 24 or 25 hours (daylight saving). | ||
| * | ||
| * @since 1.5.0 |
There was a problem hiding this comment.
Just a question: @cloud-fan .
Although this is technically correct, if this is going to public in 3.00, @since 3.0.0 is better?
There was a problem hiding this comment.
If this is 1.5.0, people will get confused and may try to use it 2.4.x.
There was a problem hiding this comment.
this is a good point. Do we have a clear rule about how to decide the since version. To me 3.0 is better here, as we've changed this class a lot in 3.0.
There was a problem hiding this comment.
checked the java doc about since https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since
When a class (or interface) is introduced, specify one since tag in its class description and no since tags in the members. Add a since tag only to members added in a later version than the class. ...
If a member changes from protected to public in a later release, the since tag would not change, even though it is now usable by any caller, not just subclassers.
1.5.0 should be fine I guess
There was a problem hiding this comment.
... the since tag would not change ...
This is different from what we are facing here. We are adding a since tag. not changing an existing one.
There was a problem hiding this comment.
raise a followup to fix this #27299, thanks @dongjoon-hyun @cloud-fan
What changes were proposed in this pull request?
CalendarIntervalis maintained as a private class but might be used in a public way by userse.g.
And it exists since 1.5.0, now we go to the 3.x era,may be it's time to make it public
Why are the changes needed?
make the interval more future-proofing
Does this PR introduce any user-facing change?
doc change
How was this patch tested?
add ut.