Skip to content

Conversation

@HeartSaVioR
Copy link
Contributor

@HeartSaVioR HeartSaVioR commented Jan 10, 2020

What changes were proposed in this pull request?

This patch increases the memory limit in the test 'test_memory_limit' from 1m to 8m.
Credit to @srowen and @HyukjinKwon to provide the idea of suspicion and guide how to fix.

Why are the changes needed?

We observed consistent Pyspark test failures on multiple PRs (#26955, #26201, #27064) which block the PR builds whenever the test is included.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Jenkins builds passed in WIP PR (#27159)

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Jan 10, 2020

In case if the PR build doesn't take the test (I think it shouldn't, but), I'll also trigger the build in #27159 couple more times.

@viirya
Copy link
Member

viirya commented Jan 10, 2020

any idea on why this change is needed now?

@SparkQA
Copy link

SparkQA commented Jan 10, 2020

Test build #116449 has finished for PR 27162 at commit 7c77ec7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor Author

HeartSaVioR commented Jan 10, 2020

Sorry I have no idea. I guess there's some change on Jenkins env. or code change might affect, but it's not easy to figure out why it's failing in either way only to investigate on log file. The change also doesn't hurt.

cc. @shaneknapp Do you have any idea on changes in Jenkins env.? The test suddenly started to fail yesterday, and we seem to have to increase memory limit on the test to fix it.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jan 10, 2020

I am going to merge to unblock those PRs.

Merged to master.

@HeartSaVioR
Copy link
Contributor Author

Thanks for the quick reaction! Let's see builds for these PRs pass.

@HeartSaVioR HeartSaVioR deleted the SPARK-30480 branch January 10, 2020 08:48
@HeartSaVioR
Copy link
Contributor Author

Looks like the builds are still failing from previous PRs, though I'm not sure why the builds in new WIP PR were succeeded.

@HyukjinKwon
Copy link
Member

I'll revert this and take a look tomorrow if that's still persistent.

@HyukjinKwon
Copy link
Member

Reverted.

@shaneknapp
Copy link
Contributor

Sorry I have no idea. I guess there's some change on Jenkins env. or code change might affect, but it's not easy to figure out why it's failing in either way only to investigate on log file. The change also doesn't hurt.

cc. @shaneknapp Do you have any idea on changes in Jenkins env.? The test suddenly started to fail yesterday, and we seem to have to increase memory limit on the test to fix it.

nope, the jenkins python envs haven't changed at all and i'm not sure what's going on here.

i'll take a closer look monday...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants