-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30480][PYSPARK][TESTS] Fix 'test_memory_limit' on pyspark test #27162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In case if the PR build doesn't take the test (I think it shouldn't, but), I'll also trigger the build in #27159 couple more times. |
|
any idea on why this change is needed now? |
|
Test build #116449 has finished for PR 27162 at commit
|
|
Sorry I have no idea. I guess there's some change on Jenkins env. or code change might affect, but it's not easy to figure out why it's failing in either way only to investigate on log file. The change also doesn't hurt. cc. @shaneknapp Do you have any idea on changes in Jenkins env.? The test suddenly started to fail yesterday, and we seem to have to increase memory limit on the test to fix it. |
|
I am going to merge to unblock those PRs. Merged to master. |
|
Thanks for the quick reaction! Let's see builds for these PRs pass. |
|
Looks like the builds are still failing from previous PRs, though I'm not sure why the builds in new WIP PR were succeeded. |
|
I'll revert this and take a look tomorrow if that's still persistent. |
|
Reverted. |
nope, the jenkins python envs haven't changed at all and i'm not sure what's going on here. i'll take a closer look monday... |
What changes were proposed in this pull request?
This patch increases the memory limit in the test 'test_memory_limit' from 1m to 8m.
Credit to @srowen and @HyukjinKwon to provide the idea of suspicion and guide how to fix.
Why are the changes needed?
We observed consistent Pyspark test failures on multiple PRs (#26955, #26201, #27064) which block the PR builds whenever the test is included.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Jenkins builds passed in WIP PR (#27159)