[DO-NOT-MERGE] Testing fix for pyspark test test_memory_limit #27159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added SparkUncaughtExceptionHandlerSuite
SparkUncaughtExceptionHandlerSuite had wrong name use toBoolean/toString for converting string to/from boolean exception throwers now check args.length before using args(0)
use Seq().foreach() to launch the test-cases
|
Test build #116441 has finished for PR 27159 at commit
|
Contributor
Author
|
retest this, please |
Contributor
Author
|
retest this, please |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 10, 2020
### What changes were proposed in this pull request? This patch increases the memory limit in the test 'test_memory_limit' from 1m to 8m. Credit to srowen and HyukjinKwon to provide the idea of suspicion and guide how to fix. ### Why are the changes needed? We observed consistent Pyspark test failures on multiple PRs (#26955, #26201, #27064) which block the PR builds whenever the test is included. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins builds passed in WIP PR (#27159) Closes #27162 from HeartSaVioR/SPARK-30480. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
|
Test build #116451 has finished for PR 27159 at commit
|
|
Test build #116450 has finished for PR 27159 at commit
|
Contributor
Author
|
3 tests ran so far, 1 failed from other flaky test, 2 passed. Looks like working so far. Closing. |
HeartSaVioR
deleted the
WIP-PR-26955-testing-pyspark-test-test_memory_limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore the content; will raise another PR once the patch fixes the test.