Skip to content

[SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType #26811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amanomer wants to merge 6 commits into from
Closed

[SPARK-29600][SQL] ArrayContains function may return incorrect result for DecimalType #26811

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a186dfd
Initial commit
amanomer Dec 9, 2019
71b7ad3
Test case
amanomer Dec 9, 2019
d2ce3ae
Updated migration guide
amanomer Dec 9, 2019
7412368
findWiderTypeForTwo -> findWiderTypeWithoutStringPromotionForTwo
amanomer Dec 12, 2019
6c3545d
revert migration guide changes
amanomer Dec 12, 2019
7b12d6c
Split UT
amanomer Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ case class ArrayContains(left: Expression, right: Expression)
(left.dataType, right.dataType) match {
case (_, NullType) => Seq.empty
case (ArrayType(e1, hasNull), e2) =>
TypeCoercion.findTightestCommonType(e1, e2) match {
TypeCoercion.findWiderTypeForTwo(e1, e2) match {

@HyukjinKwon HyukjinKwon Dec 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of things need a justification and migration guide update with tests. Which JIRA caused this issue?

@amanomer amanomer Dec 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #22408 which is to prevent implicit downcasting of right expression.
It doesn't handle the case of decimal type upcasting.

@amanomer amanomer Dec 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update migration guide.

case Some(dt) => Seq(ArrayType(dt, hasNull), dt)
case _ => Seq.empty
}
Expand Down