Skip to content

Comments

[SPARK-28878][SQL][followup] Remove extra project for DSv2 streaming scan#25727

Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan:follow
Closed

[SPARK-28878][SQL][followup] Remove extra project for DSv2 streaming scan#25727
cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan:follow

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

Remove the project node if the streaming scan is columnar

Why are the changes needed?

This is a followup of #25586. Batch and streaming share the same DS v2 read API so both can support columnar reads. We should apply #25586 to streaming scan as well.

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

@cloud-fan
Copy link
Contributor Author

cc @brkyvz @jose-torres @rdblue

@SparkQA
Copy link

SparkQA commented Sep 9, 2019

Test build #110341 has finished for PR 25727 at commit b21a767.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloud-fan
Copy link
Contributor Author

thanks for the review, merging to master!

@cloud-fan cloud-fan closed this in c2d8ee9 Sep 10, 2019
PavithraRamachandran pushed a commit to PavithraRamachandran/spark that referenced this pull request Sep 15, 2019
…scan

### What changes were proposed in this pull request?

Remove the project node if the streaming scan is columnar

### Why are the changes needed?

This is a followup of apache#25586. Batch and streaming share the same DS v2 read API so both can support columnar reads. We should apply apache#25586 to streaming scan as well.

### Does this PR introduce any user-facing change?

no

### How was this patch tested?

existing tests

Closes apache#25727 from cloud-fan/follow.

Authored-by: Wenchen Fan <wenchen@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants