[SPARK-28878][SQL] Remove extra project for DSv2 reads with columnar batches#25586
Closed
rdblue wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-28878][SQL] Remove extra project for DSv2 reads with columnar batches#25586rdblue wants to merge 1 commit intoapache:masterfrom
rdblue wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #109757 has finished for PR 25586 at commit
|
Contributor
Author
|
Retest this please. |
|
Test build #109828 has finished for PR 25586 at commit
|
rdblue
changed the title
|
@rdblue This looks very useful and pertinent to Vectorization support use-case in DSV2 and should help in further improving performance. Thanks for working on this! |
rdblue
changed the title
Contributor
Author
|
@prodeezy, I just needed to verify that there are tests for the columnar path and there are: |
Contributor
Author
|
@brkyvz, can you take a look at this? |
Contributor
|
thanks, merging to master! |
cloud-fan
reviewed
Sep 5, 2019
|
|
||
| // always add the projection, which will produce unsafe rows required by some operators | ||
| ProjectExec(project, withFilter) :: Nil | ||
| val withProjection = if (withFilter.output != project || !batchExec.supportsColumnar) { |
Contributor
There was a problem hiding this comment.
BTW, shall we do the same for streaming scan?
Contributor
Author
There was a problem hiding this comment.
I'm not as familiar with the streaming side. If we support columnar reads there, we probably can.
Contributor
Author
|
Thanks for merging this, @cloud-fan! |
cloud-fan
added a commit
that referenced
this pull request
Sep 10, 2019
…scan ### What changes were proposed in this pull request? Remove the project node if the streaming scan is columnar ### Why are the changes needed? This is a followup of #25586. Batch and streaming share the same DS v2 read API so both can support columnar reads. We should apply #25586 to streaming scan as well. ### Does this PR introduce any user-facing change? no ### How was this patch tested? existing tests Closes #25727 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
…batches ### What changes were proposed in this pull request? Remove unnecessary physical projection added to ensure rows are `UnsafeRow` when the DSv2 scan is columnar. This is not needed because conversions are automatically added to convert from columnar operators to `UnsafeRow` when the next operator does not support columnar execution. ### Why are the changes needed? Removes an extra projection and copy. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#25586 from rdblue/SPARK-28878-remove-dsv2-project-with-columnar. Authored-by: Ryan Blue <blue@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
…scan ### What changes were proposed in this pull request? Remove the project node if the streaming scan is columnar ### Why are the changes needed? This is a followup of apache#25586. Batch and streaming share the same DS v2 read API so both can support columnar reads. We should apply apache#25586 to streaming scan as well. ### Does this PR introduce any user-facing change? no ### How was this patch tested? existing tests Closes apache#25727 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unnecessary physical projection added to ensure rows are
UnsafeRowwhen the DSv2 scan is columnar. This is not needed because conversions are automatically added to convert from columnar operators toUnsafeRowwhen the next operator does not support columnar execution.Why are the changes needed?
Removes an extra projection and copy.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.