Skip to content

[SPARK-28797][DOC] Document DROP FUNCTION statement in SQL Reference. #25553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandeep-katta wants to merge 11 commits into from
Closed

[SPARK-28797][DOC] Document DROP FUNCTION statement in SQL Reference. #25553

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
104ccd4
added description for drop function
sandeep-katta Aug 21, 2019
1c02c3d
updated the sentence
sandeep-katta Aug 23, 2019
e90795a
Update review comments
sandeep-katta Sep 12, 2019
ef97031
Update review comments
sandeep-katta Sep 13, 2019
f458a7e
Update review comments
sandeep-katta Sep 13, 2019
9b3e2f9
change user to USER and add try to drop function which is not present
sandeep-katta Sep 17, 2019
54aad6b
differentiate temp and permanent function
sandeep-katta Sep 17, 2019
c9b7314
update review comments
sandeep-katta Sep 23, 2019
24a13f8
updated sentence
sandeep-katta Oct 3, 2019
48f925a
review comments fix
sandeep-katta Oct 4, 2019
1d3b665
review comments fix
sandeep-katta Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions docs/sql-ref-syntax-ddl-drop-function.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,18 @@ SHOW USER FUNCTIONS;
| default.test_avg |
+-------------------+

Copy link
Contributor

@dilipbiswal dilipbiswal Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: delete this line ?

-- Create Temporary function `temp_avg`
CREATE TEMPORARY FUNCTION temp_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';

Copy link
Contributor

@dilipbiswal dilipbiswal Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: delete this line ?

-- List user functions
SHOW USER FUNCTIONS;
+-------------------+
| function |
+-------------------+
| default.test_avg |
| temp_avg |
Copy link
Member

@gatorsmile gatorsmile Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the functions having the same name?

Copy link
Contributor Author

@sandeep-katta sandeep-katta Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, one with permanent and other with Temporary

Copy link
Contributor

@dilipbiswal dilipbiswal Sep 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gatorsmile The permanent functions are always shown as database qualified where as the temporary functions are not qualified. Oh.. oops :-) one is test_avg and the other is temp_avg.. . @sandeep-katta can you check, please ?

Copy link
Contributor Author

@sandeep-katta sandeep-katta Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :), sorry I corrected it

image

+-------------------+

-- Drop Permanent function
DROP FUNCTION test_avg;
+---------+
Expand All @@ -72,9 +84,14 @@ DROP FUNCTION test_avg;
org.apache.spark.sql.catalyst.analysis.NoSuchPermanentFunctionException:
Function 'default.test_avg' not found in database 'default'; (state=,code=0)

-- Create Temporary function `temp_avg`
CREATE TEMPORARY FUNCTION temp_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';

-- List the functions after dropping, it should list only temporary function
SHOW USER FUNCTIONS;
+-----------+
| function |
+-----------+
| temp_avg |
Copy link
Contributor

@dilipbiswal dilipbiswal Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeep-katta Why is it temp_avg here ? Shouldn't it be temporary function test_avg ?

Copy link
Member

@srowen srowen Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @sandeep-katta to fix that part

+-----------+

-- Drop Temporary function
DROP TEMPORARY FUNCTION IF EXISTS temp_avg;
Copy link
Contributor

@dilipbiswal dilipbiswal Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeep-katta same question :-)

+---------+
Expand Down