[SPARK-28797][DOC] Document DROP FUNCTION statement in SQL Reference. #25553

sandeep-katta · 2019-08-22T10:44:32Z

What changes were proposed in this pull request?

Add DROP FUNCTION sql description in SQL reference

Why are the changes needed?

Currently from spark there is no complete sql guide is present, so it is better to document all the sql commands, this jira is sub part of this task.

Does this PR introduce any user-facing change?

Yes before user cannot find any reference for drop function command in the spark docs.

After Fix:

How was this patch tested?

tested with jekyll build

dilipbiswal · 2019-08-23T03:14:42Z

docs/sql-ref-syntax-ddl-drop-function.md

This does not sound right. We are talking about create in a drop action ?

dilipbiswal · 2019-08-23T03:25:07Z

docs/sql-ref-syntax-ddl-drop-function.md

How about -
"If specified, no exception is thrown when the function does not exist"

dilipbiswal · 2019-09-12T07:35:44Z

@sandeep-katta Hello, could you please update this by following the convention of existing merged PRS. Thanks a lot.
#25529
#25525

sandeep-katta · 2019-09-13T06:16:50Z

@dilipbiswal can you help me review this please

dilipbiswal · 2019-09-13T06:33:30Z

docs/sql-ref-syntax-ddl-drop-function.md


-**This page is under construction**
+### Description
+Dropping a user-defined function(UDF). An exception will be thrown if the function does not exist


DROP FUNCTION statement drops a temporary or user defined function(UDF)

dilipbiswal · 2019-09-13T06:35:01Z

docs/sql-ref-syntax-ddl-drop-function.md

+### Example
+{% highlight sql %}
+-- Create a permanent function `test_avg`
+


delete this line ?

dilipbiswal · 2019-09-13T06:35:17Z

docs/sql-ref-syntax-ddl-drop-function.md

+CREATE FUNCTION test_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';
+
+-- List user functions 
+


Nit: delete this line ?

dilipbiswal · 2019-09-13T06:35:34Z

docs/sql-ref-syntax-ddl-drop-function.md

+-- List user functions 
+
+SHOW user functions;
+


Nit: delete this line ?

dilipbiswal · 2019-09-13T06:36:08Z

docs/sql-ref-syntax-ddl-drop-function.md

+
+SHOW user functions;
+
+-------------------+


Nit: Shift this by 2 space to align with other prs.

dilipbiswal · 2019-09-13T06:36:22Z

docs/sql-ref-syntax-ddl-drop-function.md

+-- Drop Permanent function
+
+DROP FUNCTION test_avg;
+---------+


Nit: Shift this by 2 space to align with other prs.

dilipbiswal · 2019-09-13T06:36:47Z

docs/sql-ref-syntax-ddl-drop-function.md

+CREATE TEMPORARY FUNCTION temp_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';
+
+-- Drop Temporary function
+


Nit: delete this line.

dilipbiswal · 2019-09-13T06:37:00Z

docs/sql-ref-syntax-ddl-drop-function.md

+-- Drop Temporary function
+
+DROP TEMPORARY FUNCTION IF EXISTS temp_avg;
+---------+


Nit: Shift this by 2 space to align with other prs.

dilipbiswal · 2019-09-13T06:37:16Z

docs/sql-ref-syntax-ddl-drop-function.md

+| Result  |
+---------+
+---------+
+


Nit: delete this line ?

dilipbiswal · 2019-09-13T07:25:08Z

LGTM
cc @gatorsmile

gatorsmile · 2019-09-15T16:38:34Z

ok to test

docs/sql-ref-syntax-ddl-drop-function.md

SparkQA · 2019-09-15T17:35:10Z

Test build #110628 has finished for PR 25553 at commit f458a7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

viirya · 2019-09-15T17:42:02Z

docs/sql-ref-syntax-ddl-drop-function.md

+CREATE FUNCTION test_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';
+
+-- List user functions
+SHOW user functions;


SHOW user functions; -> SHOW USER FUNCTIONS;?

SparkQA · 2019-09-17T04:46:18Z

Test build #110734 has finished for PR 25553 at commit 9b3e2f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2019-09-17T07:06:42Z

We need to show the precedence of temp view and table when they share the same name.

SparkQA · 2019-09-17T09:28:26Z

Test build #110770 has finished for PR 25553 at commit 54aad6b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2019-09-20T21:01:57Z

docs/sql-ref-syntax-ddl-drop-function.md

+  |     function      |
+  +-------------------+
+  | default.test_avg  |
+  | temp_avg          |


Are the functions having the same name?

yes, one with permanent and other with Temporary

@gatorsmile The permanent functions are always shown as database qualified where as the temporary functions are not qualified. Oh.. oops :-) one is test_avg and the other is temp_avg.. . @sandeep-katta can you check, please ?

oops :), sorry I corrected it

SparkQA · 2019-09-23T01:56:41Z

Test build #111178 has finished for PR 25553 at commit c9b7314.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

sandeep-katta · 2019-10-03T10:33:08Z

@dilipbiswal @gatorsmile does any more changes are required for this PR ?

srowen · 2019-10-03T13:51:03Z

docs/sql-ref-syntax-ddl-drop-function.md


-**This page is under construction**
+### Description
+`DROP FUNCTION` statement drops a temporary or user defined function(UDF). An exception will be thrown if the function does not exist


Nit: Add "The" at the start. Also, space before (UDF). What does 'in the system' mean - can we just drop this or make it more specific?

SparkQA · 2019-10-03T14:28:14Z

Test build #111739 has finished for PR 25553 at commit 24a13f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

docs/sql-ref-syntax-ddl-drop-function.md

SparkQA · 2019-10-04T03:00:28Z

Test build #111762 has finished for PR 25553 at commit 48f925a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dilipbiswal · 2019-10-04T19:33:32Z

docs/sql-ref-syntax-ddl-drop-function.md

+  +-----------+
+  | function  |
+  +-----------+
+  | temp_avg  |


@sandeep-katta Why is it temp_avg here ? Shouldn't it be temporary function test_avg ?

Ping @sandeep-katta to fix that part

dilipbiswal · 2019-10-04T19:33:56Z

docs/sql-ref-syntax-ddl-drop-function.md

+  +-----------+
+
+-- Drop Temporary function
+DROP TEMPORARY FUNCTION IF EXISTS temp_avg;


@sandeep-katta same question :-)

srowen · 2019-10-08T13:14:18Z

docs/sql-ref-syntax-ddl-drop-function.md

+  +-----------+
+  | function  |
+  +-----------+
+  | temp_avg  |


Ping @sandeep-katta to fix that part

SparkQA · 2019-10-08T14:50:10Z

Test build #111895 has finished for PR 25553 at commit 1d3b665.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2019-10-09T00:47:46Z

Merged to master

### What changes were proposed in this pull request? Add DROP FUNCTION sql description in SQL reference ### Why are the changes needed? Currently from spark there is no complete sql guide is present, so it is better to document all the sql commands, this jira is sub part of this task. ### Does this PR introduce any user-facing change? Yes before user cannot find any reference for drop function command in the spark docs. After Fix: ![image](https://user-images.githubusercontent.com/35216143/66134570-240cd300-e616-11e9-9c78-259c0d355378.png) ![image](https://user-images.githubusercontent.com/35216143/65397825-d059e880-ddd0-11e9-8bd3-a65ccae56063.png) ![image](https://user-images.githubusercontent.com/35216143/66404731-9f032e80-ea06-11e9-8fef-1e266efa4c66.png) ### How was this patch tested? tested with jekyll build Closes apache#25553 from sandeep-katta/28797. Authored-by: sandeep katta <[email protected]> Signed-off-by: Sean Owen <[email protected]>

dongjoon-hyun added SQL DOCUMENTATION labels Aug 22, 2019

dilipbiswal reviewed Aug 23, 2019

View reviewed changes

sandeep-katta added 3 commits September 12, 2019 14:55

added description for drop function

104ccd4

updated the sentence

1c02c3d

Update review comments

e90795a

sandeep-katta force-pushed the 28797 branch from e254049 to e90795a Compare September 12, 2019 11:19

dilipbiswal reviewed Sep 13, 2019

View reviewed changes

sandeep-katta added 2 commits September 13, 2019 12:23

Update review comments

ef97031

Update review comments

f458a7e

gatorsmile reviewed Sep 15, 2019

View reviewed changes

docs/sql-ref-syntax-ddl-drop-function.md Show resolved Hide resolved

viirya reviewed Sep 15, 2019

View reviewed changes

change user to USER and add try to drop function which is not present

9b3e2f9

differentiate temp and permanent function

54aad6b

gatorsmile reviewed Sep 20, 2019

View reviewed changes

update review comments

c9b7314

srowen reviewed Oct 3, 2019

View reviewed changes

updated sentence

24a13f8

srowen reviewed Oct 3, 2019

View reviewed changes

docs/sql-ref-syntax-ddl-drop-function.md Outdated Show resolved Hide resolved

review comments fix

48f925a

srowen approved these changes Oct 4, 2019

View reviewed changes

dilipbiswal reviewed Oct 4, 2019

View reviewed changes

srowen requested changes Oct 8, 2019

View reviewed changes

review comments fix

1d3b665

srowen approved these changes Oct 8, 2019

View reviewed changes

srowen closed this in 69b0cc1 Oct 9, 2019

		CREATE FUNCTION test_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';

		-- List user functions

		CREATE TEMPORARY FUNCTION temp_avg as 'org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage';

		-- Drop Temporary function

[SPARK-28797][DOC] Document DROP FUNCTION statement in SQL Reference. #25553

[SPARK-28797][DOC] Document DROP FUNCTION statement in SQL Reference. #25553

Uh oh!

Conversation

sandeep-katta commented Aug 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dilipbiswal commented Sep 12, 2019

Uh oh!

sandeep-katta commented Sep 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dilipbiswal commented Sep 13, 2019

Uh oh!

gatorsmile commented Sep 15, 2019

Uh oh!

Uh oh!

SparkQA commented Sep 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 17, 2019

Uh oh!

gatorsmile commented Sep 17, 2019

Uh oh!

SparkQA commented Sep 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dilipbiswal Sep 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 23, 2019

Uh oh!

sandeep-katta commented Oct 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Oct 3, 2019

Uh oh!

Uh oh!

SparkQA commented Oct 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

sandeep-katta commented Aug 22, 2019 •

edited

Loading

dilipbiswal Sep 22, 2019 •

edited

Loading