[MINOR][SQL] Clean up ObjectProducerExec operators #25065
Conversation
|
Test build #107306 has finished for PR 25065 at commit
|
|
Hi, @jaceklaskowski . Could you make a JIRA issue for this? Thanks. |
|
A JIRA won't hurt but this looks like just a code cleanup; there should be no functional change. |
|
@dongjoon-hyun When I created the PR I thought to make a JIRA issue, but it's just a simple refactoring (code cleanup) so I don't think it begs for one. |
|
Okay. Then, I leave this PR to the other reviews. |
|
I'm fine either way. I also prefer to have a JIRA in general for trackability, for instance, backporting stuff. I think this PR is boundary between no JIRA and JIRA :-). As an example, there was a recent and rather similar change at #25052 with JIRA so it's not a bad idea to have a JIRA. |
|
Merged to master. I think it's fine. |
## What changes were proposed in this pull request? Cleaned up (removed) code duplication in `ObjectProducerExec` operators so they use the trait's methods. ## How was this patch tested? Local build. Waiting for Jenkins. Closes apache#25065 from jaceklaskowski/ObjectProducerExec-operators-cleanup. Authored-by: Jacek Laskowski <[email protected]> Signed-off-by: Sean Owen <[email protected]>
5 participants
What changes were proposed in this pull request?
Cleaned up (removed) code duplication in
ObjectProducerExecoperators so they use the trait's methods.How was this patch tested?
Local build. Waiting for Jenkins.