[SPARK-28250][SQL] QueryPlan#references should exclude producedAttributes #25052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #107234 has finished for PR 25052 at commit
|
viirya
reviewed
Jul 4, 2019
Contributor
Author
There was a problem hiding this comment.
It seems like cheating if we override this method. We want to know if the plan is valid or not by this method, overriding this method means we skip this validation.
Member
There was a problem hiding this comment.
Ok. I think it makes sense to me. We should update this comment.
|
Test build #107242 has finished for PR 25052 at commit
|
viirya
reviewed
Jul 5, 2019
|
|
||
| override def outputPartitioning: Partitioning = child.outputPartitioning | ||
|
|
||
| override def producedAttributes: AttributeSet = AttributeSet(outputObjAttr) |
Member
There was a problem hiding this comment.
Isn't outputObjAttr produced by FlatMapGroupsInRExec?
Contributor
Author
There was a problem hiding this comment.
This is a no-op override, it's the same as ObjectProducerExec.producedAttributes
viirya
approved these changes
Jul 5, 2019
|
Test build #107247 has finished for PR 25052 at commit
|
HyukjinKwon
approved these changes
Jul 9, 2019
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of the discussion in #24675 (comment)
QueryPlan#referencesis an important property. TheColumnPrunningrule relies on it.Some query plan nodes have
Seq[Attribute]parameter, which is used as its output attributes. For example, leaf nodes,Generate,MapPartitionsInPandas, etc. These nodes overrideproducedAttributesto makemissingInputscorrect.However, these nodes also need to override
referencesto make column pruning work. This PR proposes to excludeproducedAttributesfrom the default implementation ofQueryPlan#references, so that we don't need to overridereferencesin all these nodes.Note that, technically we can remove
producedAttributesand always ask query plan nodes to overridereferences. But I do find the code can be simpler withproducedAttributesin some places, where there is a base class for some specific query plan nodes.How was this patch tested?
existing tests