Skip to content

[SPARK-26424][SQL][FOLLOWUP] Fix DateFormatClass/UnixTime codegen #23394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-26424][SQL][FOLLOWUP] Fix DateFormatClass/UnixTime codegen #23394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...talyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ case class DateFormatClass(left: Expression, right: Expression, timeZoneId: Opti
val tz = ctx.addReferenceObj("timeZone", timeZone)
val locale = ctx.addReferenceObj("locale", Locale.US)
defineCodeGen(ctx, ev, (timestamp, format) => {
s"""UTF8String.fromString($tf.apply($format.toString(), $tz, $locale)
s"""UTF8String.fromString($tf$$.MODULE$$.apply($format.toString(), $tz, $locale)
Copy link
Contributor

@cloud-fan cloud-fan Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is apply a special case? IIRC java can call methods in scala object, just like calling static methods.

Copy link
Member

@srowen srowen Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static methods are methods of the companion object, so yeah you need to access static methods like this in Java.

Copy link
Member

@HyukjinKwon HyukjinKwon Dec 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is pretty annoying when you access to it in Python side via Py4J .. !!

.format($timestamp))"""
})
}
Expand Down Expand Up @@ -741,11 +741,11 @@ abstract class UnixTime
case StringType =>
val tz = ctx.addReferenceObj("timeZone", timeZone)
val locale = ctx.addReferenceObj("locale", Locale.US)
val dtu = TimestampFormatter.getClass.getName.stripSuffix("$")
val tf = TimestampFormatter.getClass.getName.stripSuffix("$")
nullSafeCodeGen(ctx, ev, (string, format) => {
s"""
try {
${ev.value} = $dtu.apply($format.toString(), $tz, $locale)
${ev.value} = $tf$$.MODULE$$.apply($format.toString(), $tz, $locale)
.parse($string.toString()) / 1000000L;
} catch (java.lang.IllegalArgumentException e) {
${ev.isNull} = true;
Expand Down