[SPARK-26424][SQL][FOLLOWUP] Fix DateFormatClass/UnixTime codegen #23394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @MaxGekk , @cloud-fan , @HyukjinKwon |
HyukjinKwon
approved these changes
Dec 28, 2018
Member
Author
|
Thank you for review and approval, @HyukjinKwon . |
Member
|
@dongjoon-hyun Thank you for the fix. Do you know are there any ways to run a PR branch on scala 2.11 in jenkins somehow. |
cloud-fan
reviewed
Dec 28, 2018
| val locale = ctx.addReferenceObj("locale", Locale.US) | ||
| defineCodeGen(ctx, ev, (timestamp, format) => { | ||
| s"""UTF8String.fromString($tf.apply($format.toString(), $tz, $locale) | ||
| s"""UTF8String.fromString($tf$$.MODULE$$.apply($format.toString(), $tz, $locale) |
Contributor
There was a problem hiding this comment.
is apply a special case? IIRC java can call methods in scala object, just like calling static methods.
Member
There was a problem hiding this comment.
The static methods are methods of the companion object, so yeah you need to access static methods like this in Java.
Member
There was a problem hiding this comment.
which is pretty annoying when you access to it in Python side via Py4J .. !!
|
Test build #100497 has finished for PR 23394 at commit
|
MaxGekk
approved these changes
Dec 28, 2018
Member
Author
|
Thank you, @HyukjinKwon , @MaxGekk , @cloud-fan , @srowen . |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
## What changes were proposed in this pull request? This PR fixes the codegen bug introduced by apache#23358 . - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-ubuntu-scala-2.11/158/ ``` Line 44, Column 93: A method named "apply" is not declared in any enclosing class nor any supertype, nor through a static import ``` ## How was this patch tested? Manual. `DateExpressionsSuite` should be passed with Scala-2.11. Closes apache#23394 from dongjoon-hyun/SPARK-26424. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR fixes the codegen bug introduced by apache#23358 . - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-ubuntu-scala-2.11/158/ ``` Line 44, Column 93: A method named "apply" is not declared in any enclosing class nor any supertype, nor through a static import ``` ## How was this patch tested? Manual. `DateExpressionsSuite` should be passed with Scala-2.11. Closes apache#23394 from dongjoon-hyun/SPARK-26424. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the codegen bug introduced by #23358 .
How was this patch tested?
Manual.
DateExpressionsSuiteshould be passed with Scala-2.11.