[MINOR][K8S] add missing docs for podTemplateContainerName properties #23155

aditanase · 2018-11-27T13:15:03Z

What changes were proposed in this pull request?

Adding docs for an enhancement that came in late in this PR: #22146
Currently the docs state that we're going to use the first container in a pod template, which was the implementation for some time, until it was improved with 2 new properties.

How was this patch tested?

I tested that the properties work by combining pod templates with client-mode and a simple pod template.

Please review http://spark.apache.org/contributing.html before opening a pull request.

aditanase · 2018-11-27T13:16:14Z

cc @mccheah @onursatici @skonto

…n docs. ## What changes were proposed in this pull request? "Running on Kubernetes" references `spark.driver.pod.name` few places, and it should be `spark.kubernetes.driver.pod.name`. ## How was this patch tested? See changes Closes #23133 from Leemoonsoo/fix-driver-pod-name-prop. Authored-by: Lee moon soo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

dongjoon-hyun · 2018-11-27T22:20:12Z

Thank you for your first contribution, @aditanase .

dongjoon-hyun · 2018-11-27T22:20:20Z

ok to test

dongjoon-hyun · 2018-11-27T22:22:19Z

docs/running-on-kubernetes.md

Could you move this to line 941 after spark.kubernetes.driver.podTemplateFile config? We had better group together spark.kubernetes.driver.* configs and spark.kubernetes.executor.* configs.

Thanks, done. I'll squash the commits before merging.

SparkQA · 2018-11-27T22:34:18Z

Test build #99341 has finished for PR 23155 at commit 157edbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2018-11-27T22:42:26Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5418/

SparkQA · 2018-11-27T22:52:46Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5418/

SparkQA · 2018-11-28T09:12:36Z

Test build #99364 has finished for PR 23155 at commit 290b764.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2018-11-28T09:19:26Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5441/

SparkQA · 2018-11-28T09:31:40Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5441/

aditanase · 2018-12-03T09:48:34Z

@dongjoon-hyun is this ok to merge? Should I squash it and ping you again?

dongjoon-hyun · 2018-12-04T03:21:15Z

Oh, I thought it could be handled by another Kubernetes committers. I'll take a look again.

dongjoon-hyun · 2018-12-04T03:38:49Z

docs/running-on-kubernetes.md

Actually, [pod template](#pod-template) is not working. Could you try the following and check with SKIP_API=1 jekyll build?

<a href="#pod-template">pod template</a>

dongjoon-hyun · 2018-12-04T03:39:06Z

docs/running-on-kubernetes.md

Please fix this, too.

dongjoon-hyun · 2018-12-04T03:39:19Z

docs/running-on-kubernetes.md

dongjoon-hyun · 2018-12-04T03:39:28Z

docs/running-on-kubernetes.md

srowen · 2018-12-28T16:14:08Z

Ping @aditanase

aditanase · 2019-01-07T13:34:17Z

@dongjoon-hyun Thanks for catching the broken anchors. Fixed them per your suggestion and tested with a jekyll build. Should work now.

@srowen my apologies, I've been on an extended winter break. I've rebased against master and squashed my commits - should be ready to merge.

SparkQA · 2019-01-07T13:44:12Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6778/

SparkQA · 2019-01-07T13:45:32Z

Test build #100886 has finished for PR 23155 at commit 2f663f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2019-01-07T13:51:43Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6779/

SparkQA · 2019-01-07T13:54:41Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6778/

SparkQA · 2019-01-07T14:02:41Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6779/

srowen · 2019-01-08T01:03:59Z

Merged to master

## What changes were proposed in this pull request? Adding docs for an enhancement that came in late in this PR: apache#22146 Currently the docs state that we're going to use the first container in a pod template, which was the implementation for some time, until it was improved with 2 new properties. ## How was this patch tested? I tested that the properties work by combining pod templates with client-mode and a simple pod template. Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#23155 from aditanase/k8s-readme. Authored-by: Adrian Tanase <[email protected]> Signed-off-by: Sean Owen <[email protected]>

dongjoon-hyun reviewed Nov 27, 2018

View reviewed changes

dongjoon-hyun reviewed Dec 4, 2018

View reviewed changes

docs/running-on-kubernetes.md Outdated

Copy link

Member

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this, too.

dongjoon-hyun reviewed Dec 4, 2018

View reviewed changes

docs/running-on-kubernetes.md Outdated

Copy link

Member

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

dongjoon-hyun reviewed Dec 4, 2018

View reviewed changes

docs/running-on-kubernetes.md Outdated

Copy link

Member

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

[MINOR][K8S] add missing docs for podTemplateContainerName properties.

2f663f1

aditanase force-pushed the k8s-readme branch from 7daea3c to 2f663f1 Compare January 7, 2019 13:32

srowen approved these changes Jan 7, 2019

View reviewed changes

srowen closed this in 5fb5a02 Jan 8, 2019

[MINOR][K8S] add missing docs for podTemplateContainerName properties #23155

[MINOR][K8S] add missing docs for podTemplateContainerName properties #23155

Uh oh!

Conversation

aditanase commented Nov 27, 2018

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

aditanase commented Nov 27, 2018

Uh oh!

dongjoon-hyun commented Nov 27, 2018

Uh oh!

dongjoon-hyun commented Nov 27, 2018

Uh oh!

dongjoon-hyun Nov 27, 2018

Choose a reason for hiding this comment

Uh oh!

aditanase Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Nov 27, 2018

Uh oh!

SparkQA commented Nov 27, 2018

Uh oh!

SparkQA commented Nov 27, 2018

Uh oh!

SparkQA commented Nov 28, 2018

Uh oh!

SparkQA commented Nov 28, 2018

Uh oh!

SparkQA commented Nov 28, 2018

Uh oh!

aditanase commented Dec 3, 2018

Uh oh!

dongjoon-hyun commented Dec 4, 2018

Uh oh!

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

srowen commented Dec 28, 2018

Uh oh!

aditanase commented Jan 7, 2019

Uh oh!

SparkQA commented Jan 7, 2019

Uh oh!

SparkQA commented Jan 7, 2019

Uh oh!

SparkQA commented Jan 7, 2019

Uh oh!

SparkQA commented Jan 7, 2019

Uh oh!

SparkQA commented Jan 7, 2019

Uh oh!

srowen commented Jan 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants