Skip to content

Conversation

@Leemoonsoo
Copy link
Member

What changes were proposed in this pull request?

"Running on Kubernetes" references spark.driver.pod.name few places, and it should be spark.kubernetes.driver.pod.name.

How was this patch tested?

See changes

@dongjoon-hyun
Copy link
Member

ok to test

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Nov 25, 2018

Test build #99233 has finished for PR 23133 at commit d50b312.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Thank you, @Leemoonsoo . Merged to master/branch-2.4.

asfgit pushed a commit that referenced this pull request Nov 25, 2018
…n docs.

## What changes were proposed in this pull request?

"Running on Kubernetes" references `spark.driver.pod.name` few places, and it should be `spark.kubernetes.driver.pod.name`.

## How was this patch tested?
See changes

Closes #23133 from Leemoonsoo/fix-driver-pod-name-prop.

Authored-by: Lee moon soo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit eea4a03)
Signed-off-by: Dongjoon Hyun <[email protected]>
@SparkQA
Copy link

SparkQA commented Nov 25, 2018

@asfgit asfgit closed this in eea4a03 Nov 25, 2018
@SparkQA
Copy link

SparkQA commented Nov 25, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5322/

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…n docs.

## What changes were proposed in this pull request?

"Running on Kubernetes" references `spark.driver.pod.name` few places, and it should be `spark.kubernetes.driver.pod.name`.

## How was this patch tested?
See changes

Closes apache#23133 from Leemoonsoo/fix-driver-pod-name-prop.

Authored-by: Lee moon soo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
…n docs.

## What changes were proposed in this pull request?

"Running on Kubernetes" references `spark.driver.pod.name` few places, and it should be `spark.kubernetes.driver.pod.name`.

## How was this patch tested?
See changes

Closes apache#23133 from Leemoonsoo/fix-driver-pod-name-prop.

Authored-by: Lee moon soo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit eea4a03)
Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
…n docs.

## What changes were proposed in this pull request?

"Running on Kubernetes" references `spark.driver.pod.name` few places, and it should be `spark.kubernetes.driver.pod.name`.

## How was this patch tested?
See changes

Closes apache#23133 from Leemoonsoo/fix-driver-pod-name-prop.

Authored-by: Lee moon soo <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit eea4a03)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants