Skip to content

Conversation

@JoshRosen
Copy link
Contributor

By merging #2268, which bumped the Spark version to 1.2.0-SNAPSHOT, I inadvertently broke the Mima binary compatibility tests. The issue is that we were comparing 1.2.0-SNAPSHOT against Spark 1.0.0 without using any Mima excludes. The right long-term fix for this is probably to publish nightly snapshots on Maven central and change the master branch to test binary compatibility against the current release candidate branch's snapshots until that release is finalized.

As a short-term fix until 1.1.0 is published on Maven central, I've configured the build to test the master branch for binary compatibility against the 1.1.0-RC4 jars. I'll loop back and remove the Apache staging repo as soon as 1.1.0 final is available.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just pull this into an exclude that is always run rather than version-specific? This is simply not part of the Spark API and is separately excluded from other stuff too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we could refactor this, but I was trying to scope this patch to a hotfix for the current test failures rather than more general organization / cleanup. I'll loop back to do this when addressing other Mima issues tomorrow.

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have started for PR 2315 at commit 776bc2c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have finished for PR 2315 at commit 776bc2c.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

[info] *** 3 TESTS FAILED ***
[error] Failed: Total 862, Failed 3, Errors 0, Passed 859, Ignored 6
[error] Failed tests:
[error]     org.apache.spark.DriverSuite
[error]     org.apache.spark.deploy.SparkSubmitSuite
[error] (core/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 2767 s, completed Sep 7, 2014 7:41:04 PM

Why are these tests failing intermittently?

Jenkins, retest this please.

@rxin
Copy link
Contributor

rxin commented Sep 8, 2014

Those 3 tests have been flaky. We should fix them ...

@rxin
Copy link
Contributor

rxin commented Sep 8, 2014

I'm going to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants