Skip to content

[SPARK-25653][TEST] Add tag ExtendedHiveTest for HiveSparkSubmitSuite #22642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 1 commit into from
Closed

[SPARK-25653][TEST] Add tag ExtendedHiveTest for HiveSparkSubmitSuite #22642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,13 @@ import org.apache.spark.sql.execution.command.DDLUtils
import org.apache.spark.sql.expressions.Window
import org.apache.spark.sql.hive.test.{TestHive, TestHiveContext}
import org.apache.spark.sql.types.{DecimalType, StructType}
import org.apache.spark.tags.ExtendedHiveTest
import org.apache.spark.util.{ResetSystemProperties, Utils}

/**
* This suite tests spark-submit with applications using HiveContext.
*/
@ExtendedHiveTest
Copy link
Member

@gatorsmile gatorsmile Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this tag, the test suite will still run if we do a code change in sql/hive. Right? cc @cloud-fan @vanzin

Copy link
Contributor

@vanzin vanzin Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the original intent of the tag. I believe originally it ran whenever there was a change to any of the SQL code, but not sure if the module mappings have been updated in the meantime.

Copy link
Member

@gatorsmile gatorsmile Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

class HiveSparkSubmitSuite
extends SparkSubmitTestUtils
with Matchers
Expand All @@ -46,8 +48,6 @@ class HiveSparkSubmitSuite

override protected val enableAutoThreadAudit = false

// TODO: rewrite these or mark them as slow tests to be run sparingly

override def beforeEach() {
super.beforeEach()
}
Expand Down